Search results for " " text appearing on every plugin activation or deactivation

[henry.wright]

When I activate or deactivate a plugin via the plugins page in WP admin, I get the following text appear at the top of the page next to the Plugins heading:

Search results for “ ”

The URL looks like:

wp-admin/plugins.php?activate=true&plugin_status=search&paged=1&s=+

As you can see from the URL, $s or $_REQUEST['s'] is set which results in the following line (around 414) in wp-admin/plugins.php executing:

printf( '<span class="subtitle">' . __('Search results for &#8220;%s&#8221;') . '</span>', esc_html( $s ) );

Why is $_REQUEST['s'] being set in this situation? Does it need to be?

[Clorith]

The s needs to be set to retain your plugin list view if you searched to find a plugin.

The reason you are seeing this is because a search containing only a space character has been issued (This is why you are seeing both plugin_status=search as well as s=+ as part of the address).

[henry.wright]

Hi Clorith

Thanks for the explanation. I should have included an explanation such as that in the ticket description.

May I ask why you closed the ticket?

[SergeyBiryukov]

We could probably trim $_REQUEST['s'] to discard spaces as a keyword, but this is not specific to the Plugins screen. We should do that consistently for other screens as well.

[henry.wright]

Wouldn't hurt trimming $_REQUEST['s'] if the value is only whitespace would it? The default front-end search uses that same query param as well.

[MikeHansenMe]

Trim search for plugin search

[MikeHansenMe]

Check if empty

[DrewAPicture]

Patch needs to be refreshed.

[SergeyBiryukov]

Per comment:3, this should be done consistently for all screens, not just for Plugins.

[lukecavanagh]

Patch refresh