get_post_status should use post_status = inherit instead of post_type = attachment

[ryanscheuermann]

The function get_post_status gets the inherited post_status if the post_type = 'attachment', but shouldn't it test if post_status = 'inherit' instead? I'm attempting to allow attachments to be marked "private" regardless of their parent post/page's status. It's my assumption that by default, attachments have post_status = 'inherit', so changing this line shouldn't break anything.

get_post_status should be:

function get_post_status($ID = '') {
	$post = get_post($ID);

	if ( is_object($post) ) {
		if ( ('inherit' == $post->post_status) && $post->post_parent && ($post->ID != $post->post_parent) )
			return get_post_status($post->post_parent);
		else
			return $post->post_status;
	}

	return false;
}

[nelsonrp]

patch for wp-includes/post.php to handle post_status='inherit' and also treat post_status='publish' like 'inherit' if it has a parent page

[nelsonrp]

I changed it so that post_status='publish' is just like post_status='inherit' since it is highly unlikely that the child of a 'private' page/post should not be 'private' as well. Comments welcome.