Static front page opt-in via customizer

[Clorith]

The static front page option is hidden under Settings > Reading if there are no pages available, but in the Customize screen this shows labels with no select boxes, giving the impression of something being broken.

Attached patch replicates the behavior of the settings page by only showing the static front page group if there exists any pages by doing a if ( get_pages() ) check

[SergeyBiryukov]

Related: #21492

[ElectricFeet]

Replying to Clorith:
Could you tell me if this code resolves the inconsistency that I reported here: ​http://wordpress.org/support/topic/inconsistency-in-how-wordpress-saves-front-page-options?replies=1 ?

I see that it substitutes the Customizer code with a lot of the Settings > Reading code, so it should fix that problem, but I'm a PHP newbie so cannot be sure.

If it doesn't, I'll open a new ticket for that inconsistency.

[Clorith]

Replying to ElectricFeet:

Replying to Clorith:
Could you tell me if this code resolves the inconsistency that I reported here: ​http://wordpress.org/support/topic/inconsistency-in-how-wordpress-saves-front-page-options?replies=1 ?

I see that it substitutes the Customizer code with a lot of the Settings > Reading code, so it should fix that problem, but I'm a PHP newbie so cannot be sure.

If it doesn't, I'll open a new ticket for that inconsistency.

Sorry for the delayed response.

My patch actually removes the option from the customize screen altogether if there are no pages on your site, so it would be a different case than the one you've discovered.

[danielbachhuber]

Not to hijack the thread, but I thought it might be better than creating a second ticket. Customizer says:

Your theme supports a static front page.

What if remove_theme_support( 'static-front-page' ) removed support entirely (e.g. removed the option, didn't register the Customizer Section, etc.) ?

[Clorith]

Not a bad idea, but we'd still need the check in place as some themes support both and we'd want to avoid the "broken" look when they do support a static page.

[ElectricFeet]

Replying to Clorith:

Replying to ElectricFeet:

Replying to Clorith:
Could you tell me if this code resolves the inconsistency that I reported here: ​http://wordpress.org/support/topic/inconsistency-in-how-wordpress-saves-front-page-options?replies=1 ?

I see that it substitutes the Customizer code with a lot of the Settings > Reading code, so it should fix that problem, but I'm a PHP newbie so cannot be sure.

If it doesn't, I'll open a new ticket for that inconsistency.

Sorry for the delayed response.

My patch actually removes the option from the customize screen altogether if there are no pages on your site, so it would be a different case than the one you've discovered.

Apologies for the delay in responding. Thanks for the reply Clorith.

I think I need to open another ticket...

[celloexpressions]

27630.patch​ fixes this ticket and still applies cleanly.

[SergeyBiryukov]

In 31234:

Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages.

props Clorith.
fixes #27630.