#27633 closed enhancement (fixed)
Pass plugin/theme update objects to upgrader & add plugin/theme autoupdate stats
Reported by: | dd32 | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.7 |
Component: | Upgrade/Install | Keywords: | dev-feedback |
Focuses: | Cc: |
Description
The Background Updater functionality has always had the ability for users to opt-in for plugin & theme autoupdates through the usage of plugins or filters, but we've got no stats on the effectiveness of any of these updates, or, if they're experiencing different rates of success (be it better or worse).
Currently we report autoupdate statistics to WordPress.org for Core Updates, these have been invaluable for evaluating the Background Updates successes and failures, so it makes sense to record similar data for plugins & themes as well.
Due to #27365 we only have a success or failure available to us (and no idea why it failed), but it's enough data for this purpose for now.
In adding these stats, it was discovered that we were incorrectly passing plugin/theme slugs to the updater, rather than the update offerings (which we do for Core & Translations), this change brings it inline with the expected behaviour and documentation.
There should be no significant breakage caused by that, in the worst case scenario someone who has explicitly opted in to receive updates for a single plugin may no longer do so, those who simply opted in to receive all updates (through add_filter( 'auto_update_plugin', '__return_true' );
as most tutorials suggest) would see no change.
Attachments (1)
Change History (13)
#2
@
10 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 27923:
#4
follow-up:
↓ 5
@
10 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Getting some warnings on plugin and theme upgrades following [27905]:
PHP Warning: json_encode(): recursion detected in /srv/www/trunk/src/wp-includes/update.php on line 261 PHP Warning: json_encode(): recursion detected in /srv/www/trunk/src/wp-includes/update.php on line 405
#5
in reply to:
↑ 4
@
10 years ago
Replying to DrewAPicture:
Getting some warnings on plugin and theme upgrades following [27905]:
PHP Warning: json_encode(): recursion detected in /srv/www/trunk/src/wp-includes/update.php on line 261 PHP Warning: json_encode(): recursion detected in /srv/www/trunk/src/wp-includes/update.php on line 405
Are these occurring during auto updates? Manual updates? A specific page?
In 27905: