WordPress.org

Make WordPress Core

#27637 closed enhancement (fixed)

Remove <br>s for HTML5 galleries

Reported by: obenland Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: Cc:

Description

HTML5 support for galleries was introduced recently (r27302). Shortly after that, we decided to seize the opportunity and disable default gallery styles, when a theme supports HTML5 galleries (r27396).

Last week, Nacin wondered if it would make sense to also remove the <br> element, that gets inserted to force line breaks. After we weighed pros and cons I asked some colleagues for their opinion, and they unanimously agreed that we should remove them. So let's do it and improve the markup even further.

Attachments (2)

27637.diff (591 bytes) - added by obenland 11 months ago.
27637.2.diff (2.4 KB) - added by obenland 11 months ago.
Includes support for 2013 and 2014

Download all attachments as: .zip

Change History (7)

@obenland11 months ago

comment:1 @ircbot11 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

@obenland11 months ago

Includes support for 2013 and 2014

comment:2 @nacin11 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27914:

Remove <br> elements for HTML5 galleries.

props obenland.
fixes #27637, see #26697.

comment:3 @obenland11 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Twenty Thirteen and Fourteen need a little attention on this.

comment:4 @lancewillett11 months ago

In 27926:

Twenty Thirteen and Fourteen: style to support the new HTML5 line-break-less galleries. Props obenland, see #27637.

comment:5 @nacin11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.