Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#27638 closed defect (bug) (duplicate)

Bad value navigation for attribute role on element ul

Reported by: gigimuschi Owned by: helen
Priority: normal Milestone:
Component: Administration Version: 3.8.1
Severity: minor Keywords: has-patch
Cc: Focuses: accessibility

Description

In the WordPress administration dashboard the menu list contains the attribute "role" with the value of "navigation" and accordingly to HTML5 this is wrong.

Code: <ul id="adminmenu" role="navigation">
Error: Bad value navigation for attribute role on element ul.

Attachments (1)

27638.diff (415 bytes ) - added by Latz 12 years ago.

Download all attachments as: .zip

Change History (9)

#1 @gigimuschi
12 years ago

  • Severity normalminor

#2 @wonderboymusic
12 years ago

  • Keywords needs-patch added
  • Milestone Awaiting ReviewFuture Release

#3 @Latz
12 years ago

  • Keywords has-patch added; needs-patch removed

According to w3c it should look like this:

<nav role="navigation">
<ul>
<li>About us</li>
<li>Services</li>
<li>Contact</li>
<li>Location</li>
<li>Why Groovy?</li>
</ul>
</nav>

@Latz
12 years ago

#4 @wonderboymusic
12 years ago

  • Milestone Future Release4.2
  • Owner set to helen
  • Status newassigned

I am not entirely sure how big or small this markup change is, I will defer to @helen

This ticket was mentioned in Slack in #core by drew. View the logs.


11 years ago

#6 @DrewAPicture
11 years ago

  • Focuses accessibility added
  • Milestone 4.2Future Release

Feedback from @helen in Slack (logs linked above):

[My] desire to mess with the markup for the admin menu right now is zero, also curious what a11y thinks of it anyway.

Let's take a look at this in 4.3.

#7 @afercia
11 years ago

Sorry first time I see this ticket, we're covering this and more landmark roles to add in the admin in #31450. For reference, to support old Assistive Technologies and old browsers, it's still recommended to use DIVs so instead of

<nav role="navigation">

we're proposing

<div role="navigation" aria-label="Main menu"> 

In the future, it will be possible to use just <nav> which has an implicit role="navigation"

#8 @SergeyBiryukov
11 years ago

  • Milestone Future Release
  • Resolutionduplicate
  • Status assignedclosed

Duplicate of #31450.

Note: See TracTickets for help on using tickets.