Theme Install page does not display errors

[johnbillion]

If the AJAX call to api.wordpress.org on the theme install screen fails, the error message which is supposed to be shown via the query:fail event does not show up.

Looks like the issue is due to the display:none here in themes.css.

[SergeyBiryukov]

Confirmed. The spinner also never disappears in that case.

[SergeyBiryukov]

27640.patch​ fixes it for me.

div.themes is removed to avoid a 100px gap between the menu and the error message. From my testing, it is reinserted after a successful AJAX call.

[SergeyBiryukov]

Actually, that gap (added along with the file in [26142]) doesn't seem to make a difference anywhere else. 27640.2.patch​ removes it from CSS.

[SergeyBiryukov]

One more take in 27640.3.patch​, just for good measure.

[matveb]

27640.3.patch looks great. I can't remember what the purpose of the 100px was.

[nacin]

In 27958:

Theme Installer: Fix displaying of errors.

props SergeyBiryukov.
fixes #27640.