WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27640 closed defect (bug) (fixed)

Theme Install page does not display errors

Reported by: johnbillion Owned by: matveb
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Themes Keywords: has-patch
Focuses: ui Cc:

Description

If the AJAX call to api.wordpress.org on the theme install screen fails, the error message which is supposed to be shown via the query:fail event does not show up.

Looks like the issue is due to the display:none here in themes.css.

Attachments (4)

27640.patch (547 bytes) - added by SergeyBiryukov 5 years ago.
27640.after.png (14.3 KB) - added by SergeyBiryukov 5 years ago.
27640.2.patch (804 bytes) - added by SergeyBiryukov 5 years ago.
27640.3.patch (660 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
5 years ago

Confirmed. The spinner also never disappears in that case.

#2 @SergeyBiryukov
5 years ago

  • Keywords has-patch added; needs-patch removed

27640.patch fixes it for me.

div.themes is removed to avoid a 100px gap between the menu and the error message. From my testing, it is reinserted after a successful AJAX call.

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#3 @SergeyBiryukov
5 years ago

Actually, that gap (added along with the file in [26142]) doesn't seem to make a difference anywhere else. 27640.2.patch removes it from CSS.

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#4 @SergeyBiryukov
5 years ago

One more take in 27640.3.patch, just for good measure.

#5 @nacin
5 years ago

  • Owner set to matveb
  • Status changed from new to assigned

#6 @matveb
5 years ago

27640.3.patch looks great. I can't remember what the purpose of the 100px was.

#7 @nacin
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 27958:

Theme Installer: Fix displaying of errors.

props SergeyBiryukov.
fixes #27640.

Note: See TracTickets for help on using tickets.