WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#27643 closed enhancement (fixed)

Subtitle/Caption format support

Reported by: joedolson's profile joedolson Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.6
Component: Media Keywords: has-patch 4.0-early commit
Focuses: accessibility Cc:

Description

At the moment, video subtitling only supports the 'vtt' format. MediaElement.js supports DFXP and SRT formats, as well, so those should be supported.

Attachments (2)

27643.patch​ (488 bytes) - added by joedolson 11 years ago.
Add support for dfxp and srt subtitle formats
27643.diff​ (1.2 KB) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (8)

@joedolson
11 years ago

Add support for dfxp and srt subtitle formats

#1 @joedolson
11 years ago

  • Keywords has-patch added

#2 @jeremyfelt
11 years ago

  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

#3 @SergeyBiryukov
11 years ago

  • Keywords 4.0-early added
  • Milestone changed from Awaiting Review to Future Release
  • Version set to 3.6

@wonderboymusic
11 years ago

#4 @wonderboymusic
11 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 4.0

Are .dfxp supposed to be application/ttaf+xml?

27643.diff​ does that.

#5 @joedolson
11 years ago

Yes, that appears to be right. Thanks.

#6 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28259:

Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement.

Props joedolson.
Fixes #27643.

Note: See TracTickets for help on using tickets.