WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#27643 closed enhancement (fixed)

Subtitle/Caption format support

Reported by: joedolson Owned by: wonderboymusic
Priority: normal Milestone: 4.0
Component: Media Version: 3.6
Severity: normal Keywords: has-patch 4.0-early commit
Cc: Focuses: accessibility

Description

At the moment, video subtitling only supports the 'vtt' format. MediaElement.js supports DFXP and SRT formats, as well, so those should be supported.

Attachments (2)

27643.patch​ (488 bytes ) - added by joedolson 12 years ago.
Add support for dfxp and srt subtitle formats
27643.diff​ (1.2 KB ) - added by wonderboymusic 12 years ago.

Download all attachments as: .zip

Change History (8)

@joedolson
12 years ago

Add support for dfxp and srt subtitle formats

#1 @joedolson
12 years ago

  • Keywords has-patch added

#2 @jeremyfelt
12 years ago

  • Type defect (bug) → enhancement
  • Version trunk

#3 @SergeyBiryukov
12 years ago

  • Keywords 4.0-early added
  • Milestone Awaiting Review → Future Release
  • Version → 3.6

@wonderboymusic
12 years ago

#4 @wonderboymusic
12 years ago

  • Keywords commit added
  • Milestone Future Release → 4.0

Are .dfxp supposed to be application/ttaf+xml?

27643.diff​ does that.

#5 @joedolson
12 years ago

Yes, that appears to be right. Thanks.

#6 @wonderboymusic
12 years ago

  • Owner set to wonderboymusic
  • Resolution → fixed
  • Status new → closed

In 28259:

Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement.

Props joedolson.
Fixes #27643.

Note: See TracTickets for help on using tickets.