WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 years ago

#27658 closed enhancement (worksforme)

Add oembed support for CodePen

Reported by: mordauk Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch reporter-feedback
Focuses: Cc:

Description

CodePen just added support for oembed and it'd be awesome if WP core supported it.

http://blog.codepen.io/2014/04/03/oembed/

Attachments (2)

27658.patch (759 bytes) - added by mordauk 5 years ago.
Adds CodePen.io support oembed
27658.diff (758 bytes) - added by JustinSainton 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @mordauk
5 years ago

  • Component changed from General to Media

@mordauk
5 years ago

Adds CodePen.io support oembed

@JustinSainton
5 years ago

#2 @mordauk
5 years ago

Went ahead and wrote a plugin for it to help gauge the need for it in the community: http://wordpress.org/plugins/codepen-oembed/

#3 @ocean90
5 years ago

  • Component changed from Media to Embeds
  • Keywords has-patch added
  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Nice stuff, but give it some time to settle in.

For reference: https://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

#4 @jtsternberg
4 years ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

I believe 2 years is adequate time to settle in. :) Any reason not to add this to the whitelist now?

#5 follow-up: @johnbillion
4 years ago

  • Keywords reporter-feedback added
  • Milestone set to Awaiting Review
  • Version 3.9 deleted

Answers to the questions on https://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers would help this get in. In addition, if Codepen supports oEmbed discovery and uses an iframe for its oEmbeds, it will be supported via the oEmbed discovery which was enabled along with WordPress embeds in 4.4.

#6 in reply to: ↑ 5 @jtsternberg
4 years ago

Replying to johnbillion:

Answers to the questions on https://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers would help this get in

  • Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”
    • Pretty sure they've all heard of it, yes.
  • If similar services are already supported, how does this service compare in terms of size, features, and backing?
    • Maybe cloudup.com is similar? But codepen, obviously, is for code only. It's a very popular service.
  • Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?
    • 41.1k followers on Twitter.
  • Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)
  • Does the service make an effort to build relationships with developers, such as through robust APIs?
    • Yes, it is, after all, a service FOR developers.
  • How old is the service?
    • 4 years or so, based on blog archives.
  • Does it have a well-established Wikipedia article? (Seriously.)
    • No
  • Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?
  • Is the provider frequently proposed?
    • See this ticket.

In addition, if Codepen supports oEmbed discovery and uses an iframe for its oEmbeds, it will be supported via the oEmbed discovery which was enabled along with WordPress embeds in 4.4.

Just tested, and it appears it does indeed work w/ the discovery feature.

#7 follow-up: @jorbin
4 years ago

@chriscoyier is a longtime member of the WordPress community and one of the cofounders of CodePen, so giving him an @ mention in case he has anything to say on this ticket.

I am inclined to call this worksforme as the discovery turned on in 4.4 enables CodePen embeds to 'just work' for users. The first image at the top of the CodePen oEmbed docs shows WordPress as an example and it isn't until you scroll down to Specifics about Using oEmbed in WordPress, they do mention the plugin, though that may not have been updated since 4.4 was released.

#8 @chriscoyier
4 years ago

Relevant things:

  • We have documentation on "Embeds and WordPress" http://blog.codepen.io/documentation/features/wordpress-plugin/ I'm happy to keep updated.
  • That documentation also notes the shortcode we offer, which allow for more control than oEmbed does. We have a separate plugin for that.
  • Jetpack (super recently) added oEmbed support for CodePen, so even more precedent.

Let me know if anyone has any more questions!

#9 in reply to: ↑ 7 ; follow-up: @jtsternberg
4 years ago

Replying to jorbin:

I am inclined to call this worksforme as the discovery turned on in 4.4 enables CodePen embeds to 'just work' for users. The first image at the top of the CodePen oEmbed docs shows WordPress as an example and it isn't until you scroll down to Specifics about Using oEmbed in WordPress, they do mention the plugin, though that may not have been updated since 4.4 was released.

Is their any upside, at this point, to including the built-in support to WordPress core? Performance? With discovery, it definitely seems more flexible for the long term.

#10 in reply to: ↑ 9 @johnbillion
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from reopened to closed

Pens on CodePen include oEmbed autodiscovery headers which means, since WordPress 4.4, CodePen URLs are embeddable without the need for the site to be whitelisted. Hooray!

Replying to jtsternberg:

Is their any upside, at this point, to including the built-in support to WordPress core?

The upside would be if CodePen wanted to use an oEmbed response that included more than just an iframe.

Note: See TracTickets for help on using tickets.