WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#27687 closed enhancement (fixed)

Remove by-reference from wp_remote_retrieve_* functions

Reported by: nacin Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 2.7
Component: HTTP API Keywords: 4.0-early has-patch
Focuses: Cc:

Description

See #27656 for explanation, reasoning, concerns, etc.

Attachments (1)

27687.diff (2.0 KB) - added by jesin 6 years ago.

Download all attachments as: .zip

Change History (5)

@jesin
6 years ago

#1 @jesin
6 years ago

  • Keywords reporter-feedback added

Is that the right patch?

# grep -r 'function wp_remote_retrieve' .

./wp-includes/http.php:function wp_remote_retrieve_headers(&$response) {
./wp-includes/http.php:function wp_remote_retrieve_header(&$response, $header) {
./wp-includes/http.php:function wp_remote_retrieve_response_code(&$response) {
./wp-includes/http.php:function wp_remote_retrieve_response_message(&$response) {
./wp-includes/http.php:function wp_remote_retrieve_body(&$response) {

#2 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28257:

Remove by-reference modifiers from arguments in wp_remote_retrieve_* functions.

Props jesin.
Fixes #27687.

#3 @wonderboymusic
6 years ago

  • Milestone changed from Future Release to 4.0

#4 @wonderboymusic
6 years ago

  • Keywords has-patch added; needs-patch reporter-feedback removed
Note: See TracTickets for help on using tickets.