WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27695 closed defect (bug) (fixed)

Theme Installer: already installed themes should indicate 'Installed'

Reported by: adamsilverstein Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Themes Keywords: has-patch dev-feedback
Focuses: javascript Cc:

Description

Currently when browsing the new theme installer, there is no indication that a theme is already installed. In both the browse and detail views, themes show an install button.

Instead we should at a minimum show that the theme is 'Installed'. Clicking the Install button in the browser actually opens the detailed view (another ticket for that), clicking the install button in the detail view on an already activated theme leads to an error.

Attachments (1)

27695.diff (4.2 KB) - added by adamsilverstein 5 years ago.
show 'Installed' on installed themes in theme installer

Download all attachments as: .zip

Change History (6)

@adamsilverstein
5 years ago

show 'Installed' on installed themes in theme installer

#1 @adamsilverstein
5 years ago

  • Keywords has-patch dev-feedback added

#2 @adamsilverstein
5 years ago

27695.diff Show Installed for installed themes on the theme installer browser and detail view.

Last edited 5 years ago by adamsilverstein (previous) (diff)

#3 follow-up: @ocean90
5 years ago

  • Milestone changed from Awaiting Review to 3.9

There is already another patch by nacin to solve this issue: https://core.trac.wordpress.org/attachment/ticket/27055/27055.34.diff

#4 in reply to: ↑ 3 @adamsilverstein
5 years ago

Replying to ocean90:

There is already another patch by nacin to solve this issue: https://core.trac.wordpress.org/attachment/ticket/27055/27055.34.diff

Ah, thanks for pointing that out. I searched trac before submitting the ticket and didn't find that patch. Both approaches seem reasonable, I will leave it up to the leads to decide how to proceed.

#5 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28025:

Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections.

props matveb.
see #27055. fixes #27695.

Note: See TracTickets for help on using tickets.