Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#27719 closed defect (bug) (fixed)

Hook Docs (65): wp-includes/general-template.php

Reported by: jesin's profile jesin Owned by: kpdesign's profile kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: docs Cc:

Description

Documentation is needed for the following hooks:

*search_form_format
*get_search_form
*loginout
*logout_url
*login_url
*register_url
*login_form_defaults
*login_form_top
*login_form_middle
*login_form_bottom
*lostpassword_url
*register
*bloginfo_url
*bloginfo
*wp_title
*single_post_title
*single_cat_title
*single_tag_title
*single_term_title
*get_archives_link
*getarchives_where
*getarchives_join
*get_calendar
*the_date
*the_modified_date
*get_the_modified_date
*the_time
*get_the_time
*get_post_time
*the_modified_time
*get_the_modified_time
*get_post_modified_time
*the_weekday
*the_weekday_date
*user_can_richedit
*wp_default_editor
*get_search_query
*the_search_query
*language_attributes
*paginate_links
*wp_admin_css_uri
*wp_admin_css
*wp_generator_type
*the_generator
*get_the_generator_{$type}

*get_header
*get_footer
*get_sidebar
*get_template_part_{$slug}
*pre_get_search_form
*wp_meta
*wp_head
*wp_footer

Attachments (7)

27719.diff (4.0 KB) - added by jesin 11 years ago.
Docs for search_form_format, get_search_form, logout_url, login_url, register_url, login_form_defaults, lostpassword_url, register, wp_title, single_post_title
27719.2.diff (5.7 KB) - added by jesin 11 years ago.
Docs for loginout, bloginfo_url, bloginfo, single_cat_title, single_tag_title, single_term_title, get_archives_link, getarchives_where, get_calendar, the_date, the_modified_date, get_the_modified_date, the_time
27719.3.diff (7.1 KB) - added by jesin 11 years ago.
Docs for get_the_time, get_post_time, the_modified_time, get_the_modified_time, get_post_modified_time, the_weekday, the_weekday_date, user_can_richedit, wp_default_editor, get_search_query, the_search_query, language_attributes, wp_admin_css_uri, wp_generator_type, the_generator, get_the_generator_{$type}
27719.4.diff (26.1 KB) - added by kpdesign 11 years ago.
Fourth pass
27719.5.diff (30.9 KB) - added by DrewAPicture 11 years ago.
Merged all the patches.
27719.6.diff (30.9 KB) - added by DrewAPicture 11 years ago.
3 fixes found in review
27719.7.diff (3.1 KB) - added by DrewAPicture 11 years ago.
3 remaining hooks

Download all attachments as: .zip

Change History (18)

#1 @jesin
11 years ago

I'll do this.

@jesin
11 years ago

Docs for search_form_format, get_search_form, logout_url, login_url, register_url, login_form_defaults, lostpassword_url, register, wp_title, single_post_title

@jesin
11 years ago

Docs for loginout, bloginfo_url, bloginfo, single_cat_title, single_tag_title, single_term_title, get_archives_link, getarchives_where, get_calendar, the_date, the_modified_date, get_the_modified_date, the_time

#2 @DrewAPicture
11 years ago

  • Owner set to jesin
  • Status changed from new to assigned

@jesin
11 years ago

Docs for get_the_time, get_post_time, the_modified_time, get_the_modified_time, get_post_modified_time, the_weekday, the_weekday_date, user_can_richedit, wp_default_editor, get_search_query, the_search_query, language_attributes, wp_admin_css_uri, wp_generator_type, the_generator, get_the_generator_{$type}

#3 @DrewAPicture
11 years ago

  • Owner changed from jesin to kpdesign
  • Status changed from assigned to reviewing

#4 @DrewAPicture
11 years ago

  • Reporter changed from DrewAPicture to jesin

@kpdesign
11 years ago

Fourth pass

#5 @DrewAPicture
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

Working to consolidate @Jesin and @kpdesign's mutual effort into a single patch.

@DrewAPicture
11 years ago

Merged all the patches.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


11 years ago

#7 @DrewAPicture
11 years ago

  • Keywords commit added

Submitting 27719.5.diff for secondary review. Please and thank you :-)

@DrewAPicture
11 years ago

3 fixes found in review

#8 @nacin
11 years ago

Good to go.

#9 @DrewAPicture
11 years ago

In 28130:

Inline documentation for hooks in wp-includes/general-template.php.

Props jesin, kpdesign.
See #27719.

@DrewAPicture
11 years ago

3 remaining hooks

#10 @DrewAPicture
11 years ago

27719.7.diff covers the 3 remaining hooks in this file, which I wanted to patch and commit separately so as to make the change more obvious and deliberate.

Documents these three hooks: login_form_top, login_form_middle, and login_form_bottom.

#11 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 28131:

Inline documentation for three remaining hooks in wp-includes/general-template.php.

Documents the login_form_top, login_form_middle, and login_form_bottom and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.

Note: See TracTickets for help on using tickets.