\${1} causing problems for people

[markjaquith]

some people are having problems with the \${1} (as opposed to
1) preg_replace() reference format.

​http://wordpress.org/support/topic/74496?replies=9

version: 2.0.3

[ryan]

Weird. PHP bug? Reverting back will break some i18n users.

[mdawaffe]

backslash numbers too?

[mdawaffe]

2744.diff

What if we backslashed numbers too? I think I counted the slashes correctly but am not positive.

[westi]

Looking at the more recent info in that support thread we are relying on something introduced in PHP 4.3.0 which is newer than some people are using.

​http://wordpress.org/about/requirements/ says we need PHP 4.2

[ryan]

4.2 bites us in the ass again.

[tenpura]

2744.diff seems to work fine. I think you counted them right.

[ryan]

backslashit() is always used in a PCRE context, at least within WP core, so this would work fine. I wonder if plugins are using backslashit() in other contexts though. Perhaps we should introduce preg_backslashit(). Also, should slash only the digit that occurs at the head of the string? That's the only unsafe one, I believe.

[mdawaffe]

Hit only the first number. mysql2date and date_i18n

[mdawaffe]

I did a grep through a good chunk of wp-plugins.org and the only place backslashit was used was in a multilingual plugin that uses it in the exact same context and so would benefit from this patch. I was not able to co everything from wp-plugins; it hung on some encoding error part way through trying to co google-sitemap-generator.

2774b.diff

1. Only replace 1st number.
2. Fix mysql3date and date_i18n

But making a new function is fine with me too:

2744c-preg.diff

1. All of the above in a new function preg_backslashit.

[mdawaffe]

preg_backslashit

[ryan]

(In [3855]) Make replacement strings backref safe without using \${1} so as to preserve php <= 4.2 compatible. Props mdawaffe. fixes #2774

[ryan]

(In [3856]) Make replacement strings backref safe without using \${1} so as to preserve php <= 4.2 compatible. Props mdawaffe. fixes #2774

[(none)]

Milestone 2.0.4 deleted