WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

#27756 closed defect (bug) (fixed)

Some similar strings in TinyMCE

Reported by: pavelevap Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version: 3.9
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

"Align left" x "Align Left"
"Align right" x "Align Right"
"Align center" x "Align Center"
"Justify" x "Justify Text"
"Words: %s" (never used) x "Word count: %s"

I can create patch if there is not any reason to preserve all these strings.

Attachments (1)

27756.patch (557 bytes) - added by pavelevap 4 years ago.

Download all attachments as: .zip

Change History (13)

#1 @pavelevap
6 years ago

There are also some other duplicates:

"Bold" x "Bold (Ctrl + B)", etc.

We used shortcuts for both editor and DFW before 3.9.

Related: #18125

#2 @pavelevap
6 years ago

"Distraction Free Writing mode" x "Distraction Free Writing"

#3 @pavelevap
4 years ago

I am not sure when it happened, but most of these issues are gone.

Only similar strings are "Words: %s" and "Word count: %s". And I am not sure if both are used or for the same reason...

#4 @pavelevap
4 years ago

OK, I found that several duplicities were "fixed" as a side effect in [32951] (file wp-mce-help.php removed).

#5 @pavelevap
4 years ago

"Bold (Ctrl + B)" was removed here: [32677]

"Distraction Free Writing mode" and "Distraction Free Writing" were replaced here: [30890]

So, there are only word count strings to close this ticket...

#6 @pavelevap
4 years ago

Words: %s - Not used in WordPress, only in original TinyMCE. I am not sure if this can be somehow used by any plugin? I tried for example TinyMCE Advanced plugin and there is still only original WP string.

Word count: %s - Used in bottom line of editor (we should preserve).

And I found another duplicate. String Code is used twice (once with context) for the same purpose (button in editor). We can remove version with context or we should add context (or translators comment) for all other strings in editor. Same approach is used for "Bold", "Bulleted list", etc. in class-wp-editor.php and script-loader.php. See attached patch.

@pavelevap
4 years ago

#7 @pavelevap
4 years ago

An one more not used string is probably Pre, we are using only Preformatted.

#8 @pavelevap
4 years ago

Strikethrough and Deleted text (strikethrough) could be also same for same buttons for consistency.

This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.


4 years ago

#10 @ocean90
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.6
  • Owner set to ocean90
  • Status changed from new to reviewing

#11 @ocean90
4 years ago

In 37441:

Editor: Merge two strings.

Props pavelevap.
See #27756.

#12 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.