Disabled button color overrides color scheme colors on save

[ryelle]

Noticed this while saving on my dev site, the disabled state of the button is always blue, no matter the color scheme in use.

[ryelle]

It looks like .disabled was added to buttons.css in [27038], but was not added to the button mixin. This is causing the default blue button to be used when saving/autosaving, no matter the color scheme selected. 27759.diff​ adds .disabled to the mixin, so the color scheme styles are used.

[nacin]

I saw this on WP.org but could not reproduce on trunk. Does it make sense that this might not always happen somehow?

[ryelle]

Replying to nacin:

I saw this on WP.org but could not reproduce on trunk. Does it make sense that this might not always happen somehow?

I don't think so... I guess if the disabled class isn't added to the button, you wouldn't see this, but I think that's always added now. It's been consistent for me across all my trunk installs.

[azaozz]

Was able to reproduce in core /build, happens on the Edit Post screen. Caused by using input.disabled and a.disabled to both style the buttons and check status from JS.

The patch fixes it.

[nacin]

Good to go.

[azaozz]

In 28079:

Fix color of disabled buttons in non-default color schemes, props ryelle, fixes #27759