Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 18 years ago

#2778 closed defect (bug) (fixed)

oops-smiley doesn work anymore

Reported by: henkvandekamer's profile HenkvandeKamer Owned by: robmiller's profile robmiller
Milestone: Priority: normal
Severity: normal Version: 2.0.2
Component: General Keywords: bg|has-patch bg|tested
Focuses: Cc:

Description

After the upgrade to WordPress 2.0.3 the :oops: doesn give the oops-smiley. I think the problem is the removal of the sort in ticket 2550. The solution is probably a one time sort of the array above the removed code? In there the :o comes before the :oops:.

Attachments (1)

2778.diff (3.2 KB) - added by robmiller 19 years ago.

Download all attachments as: .zip

Change History (7)

#1 @HenkvandeKamer
19 years ago

I do not know how to create the diff's used here (they are different from the normal diff's). But the solution is indeed place the :oops: above the :o lines. Ther is also a double :) line BTW. After the changes:

if (!isset($wpsmiliestrans)) {
        $wpsmiliestrans = array(
        ' :)'        => 'icon_smile.gif',
        ' :-)'       => 'icon_smile.gif',
        ':smile:'    => 'icon_smile.gif',
        ' :D'        => 'icon_biggrin.gif',
        ' :-D'       => 'icon_biggrin.gif',
        ':grin:'     => 'icon_biggrin.gif',
        ' :('        => 'icon_sad.gif',
        ' :-('       => 'icon_sad.gif',
        ':sad:'      => 'icon_sad.gif',
        ':oops:'     => 'icon_redface.gif',
        ' :o'        => 'icon_surprised.gif',
        ' :-o'       => 'icon_surprised.gif',
        ':eek:'      => 'icon_surprised.gif',

#2 @ryan
19 years ago

  • Milestone changed from 2.0.3 to 2.0.4

@robmiller
19 years ago

#3 @robmiller
19 years ago

  • Keywords bg|has-patch bg|tested added; oops smiley smilie removed
  • Owner changed from anonymous to robmiller
  • Status changed from new to assigned

I did a one-time sort of the array and fixed the indenting while I was at it. All sorted now :)

#4 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3889]) Sort those smilies. Props HenkvandeKamer and robmiller. fixes #2778

#5 @ryan
19 years ago

(In [3890]) Sort those smilies. Props HenkvandeKamer and robmiller. fixes #2778

#6 @(none)
18 years ago

  • Milestone 2.0.4 deleted

Milestone 2.0.4 deleted

Note: See TracTickets for help on using tickets.