Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27788 closed defect (bug) (fixed)

Reorder button in Customizer - localization problems

Reported by: pavelevap's profile pavelevap Owned by: nacin's profile nacin
Milestone: 3.9 Priority: low
Severity: trivial Version: 3.9
Component: I18N Keywords: has-patch commit
Focuses: Cc:


"Reorder" for widgets in Customizer. It seems there should be enough space, but translated string is bellow... See attached screenshot. Using Chrome.

BTW: Why there are no borders? All other Customizer buttons have nice borders...

Attachments (3)

Headers_localization_3.jpg (10.8 KB) - added by pavelevap 10 years ago.
27788.patch (391 bytes) - added by ocean90 10 years ago.
27788.diff (625 bytes) - added by nacin 10 years ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

10 years ago

10 years ago

#2 @ocean90
10 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 3.9
  • Priority changed from normal to low
  • Severity changed from normal to trivial

Noticed that as well with German translation. I think tt's save to remove the 10px margin-right. We have 10px more before it wraps, and when it wraps, you don't have the 10px gap.

#3 @nacin
10 years ago

One issue is that if these are only separated by padding, then there is no unclickable space between them. I also think that 10px is probably a bit close for these two, since one is not a button.

Rather than providing for 10px more space for translators, let's just make sure it wraps well. That means moving 10px off "Reorder" and onto the "Add a Widget" button.

10 years ago

#4 @ocean90
10 years ago

27788.diff looks good too.

#5 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28148:

Widgets: Better padding for translations of "Reorder".

fixes #27788.

Note: See TracTickets for help on using tickets.