edit multiple posts of different authors, authornames will change

[mischademuynck]

WP 3.8.2

I have multiple authors on my blog. Every week the posts get a tag with a weeknumber. Some authors forget, so weekly I check on this and 'bulk edit' the tags.
Now I saw a bug. When I make a change on multiple posts the author gets changed for all selected posts. I only change tags here. I made sure the author is not changed.

Regards,
Mischa de Muynck (www.3x50.nl)

[nacin]

Confirmed.

[nacin]

Untested

[DrewAPicture]

27792.diff​ fixes it for me on both 3.8.2 and trunk.

[SergeyBiryukov]

Introduced in [27964], partially fixed in [27990] (but not for comment_status, ping_status, or post_author).

[dd32]

untested & reverts [27990] since it's not needed with this approach, revert is 100% optional

[dd32]

27792.2.diff​ is a alternate approach to prevent this ever happening again in the future, it resets $post_data on every iteration of the posts loop.
It reverts [27990] simply due to my working copy being out of date, but that commit is optional with this approach anyway.

It seems likely this could happen again in the future since so much in that loop already modified $post_data, resetting it early just seems like a saner solution that fighting these issues..

[dd32]

I've tested my patch, and twisting it every which way that I can think of, and I can't see anything broken afterwards.

Then again, the breaking originated in my code in the first place, so I'd appreciate others eyes on it!

Nacins patch here also appears to work, and fixes this specific problem.

[DrewAPicture]

+ unit tests

[DrewAPicture]

27792.4.diff​ adds unit tests for the post_author, comment_status, and ping_status post fields following a bulk edit.

[nacin]

In 28113:

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

[nacin]

In 28114:

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Merge [28113] to the 3.8 branch.

Reverts [27991] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

[nacin]

In 28115:

Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.

Merges [28113] to the 3.7 branch.

Reverts [27992] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.