WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27821 closed defect (bug) (fixed)

wpviews: Empty video/audio playlist is not visible in TinyMCE and throws javascript errors when selected

Reported by: gcorne's profile gcorne Owned by: nacin's profile nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Editor Keywords: has-patch commit
Focuses: javascript Cc:

Description

If no valid attachments are found, when a video or audio playlist is rendered as a wpview, the empty div is not visible in TinyMCE and throws javascript errors when selected. 

Uncaught TypeError: Cannot read property 'set' of undefined wp-playlist.js?ver=3.9-RC2-src:81

We should handle this in the same way that we handle the gallery wpview.

Attachments (2)

27821-01.patch​ (4.4 KB) - added by gcorne 10 years ago.
27821-02.patch​ (4.5 KB) - added by gcorne 10 years ago.

Download all attachments as: .zip

Change History (8)

@gcorne
10 years ago

#1 @gcorne
10 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.9

27821-01.patch​ renders an error when no tracks are found that when selected shows the toolbar so that the user can add tracks or delete the playlist.

#2 @wonderboymusic
10 years ago

  • Keywords commit added

The changes gcorne makes in 27821-01.patch​ are good for protecting errors in the wild. Our features were folded in out of sync, so this gives playlists some protective parity with galleries.

This ticket was mentioned in IRC in #wordpress-dev by nacin. ​View the logs.
10 years ago

#4 @azaozz
10 years ago

Patch looks good.

@gcorne
10 years ago

This ticket was mentioned in IRC in #wordpress-dev by azaozz. ​View the logs.
10 years ago

#6 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28144:

Graceful failures for TinyMCE views of video/audio playlists.

props gcorne.
fixes #27821.

Note: See TracTickets for help on using tickets.