WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#27838 closed defect (bug) (invalid)

wp-admin/setup-config.php uses is_writable rather than win_is_writable

Reported by: israelshirk Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: Upgrade/Install Keywords:
Focuses: administration Cc:

Description

We've been compensating for this one during our packaging process for apparently a really long time - the install process mistakenly thinks it can't write wp-config.php on CIFS and windows (depending on underlying configuration) due to setup-config.php using is_writable instead of win_is_writable, which compensates for the weird behavior.

Attachments (1)

setup-config.diff (363 bytes) - added by israelshirk 6 years ago.
setup-config diff

Download all attachments as: .zip

Change History (5)

@israelshirk
6 years ago

setup-config diff

#1 @johnbillion
6 years ago

Thanks for the patch israelshirk!

WordPress has its own handy function we can use instead - wp_is_writable(). I'm not sure why it's not used everywhere we use is_writable().

#2 @israelshirk
6 years ago

Actually, the wp_is_writable suffers from the same issue on CIFS filesystems (specifically iPage, FatCow, ...) - their permissions mechanisms resemble Windows as far as PHP is concerned, but are still on Linux, so the os check in wp_is_writable doesn't catch it. Which, now that I'm looking at wp_is_writable, may have far-reaching implications. :/

As far as we've found, the only good indicator as to whether it's writable is to try like win_is_writable does.

#3 @israelshirk
6 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Resolved by vDeck TechOps today via a PHP patch.

#4 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.