Make all foreach() loops cast to array

[markjaquith]

Every so often, we get bitten by a random foreach() error due to the input not being an array.

The elegant solution is this:

foreach ( (array) $maybe_array as $foo ) :

The attached patch is just the result of a giant regular expressions find/replace:

search: foreach( *)\(( *)\$
replace: foreach$1( (array) $

this is more proof of concept than anything else. I'm not getting any errors after applying it. I'd love to banish foreach errors once and for all.

[davidhouse]

The _real_ solution is for PHP to change their crappy foreach semantics :) But yeah, nice.

[markjaquith]

Patch refresh for /trunk/

[markjaquith]

Patch refreshed for the bug hunt

[markjaquith]

Because there is a good chance this will rot many existing patches, let's wait on this until right before we release a 2.1 beta zip.

[foolswisdom]

Likely needs refresh

[Nazgul]

A candidate for doing very early in the 2.4 cycle.

[darkdragon]

I don't think bug rot will be an issue for this, since the phpdoc has done that already. Will submit updated patch.

[darkdragon]

Patch contains items which would corrupt trunk, please do not commit. Will fix issues and resubmit.

[darkdragon]

Corrected version based off of r6563 for adding array type casting to foreach loops in wp-includes folder

[darkdragon]

Updated patch fixes four spaces to tabs issue, however patch does not display in Trac, so I'm worried it won't patch for committing.

[DD32]

Replying to darkdragon:

however patch does not display in Trac, so I'm worried it won't patch for committing.

I've found that you need to save as a .diff instead of a .patch.
Simply renaming a .patch to .diff doesnt work either.

D

[darkdragon]

Is this ticket being completely ignored or is there hope that one of the patches will be applied?

[darkdragon]

If there is something that is missing then let me know and I'll add it.

[darkdragon]

What is up with this? Is this ticket defunct? Close it as won't fix if nothing is going to be done.

[santosj]

Time to update patch. Hopefully, if I'm going to spend another hour on this it will get through faster, than the last time.

[santosj]

Patch made, will upload in 1 hour.

[jacobsantos]

type casting for foreach in wp-includes.

[jacobsantos]

It is discomforting when the diff does not display.

[DD32]

It is discomforting when the diff does not display.

Try removing the extra blank line at the end of the file, I've found that causes it sometimes.. It is anoying though, I wish i could work out what causes it sometimes.

[jacobsantos]

type casting for foreach in wp-includes based off of r8483

[jacobsantos]

type casting for foreach in wp-includes based off of r8483

[jacobsantos]

Well, hopefully one of those works.

[jacobsantos]

The only problem I suppose is that this doesn't check wp-admin, which will need to be for this ticket to be closed.

[santosj]

I would rather this not go another 3 months without being looked at.

[santosj]

Suggest closing as wontfix if not going to commit.

[markjaquith]

(In [8572]) Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784