TB_iframe is placed below the left menu in WordPress 3.9

[KalleL]

TB_iframe is placed below the left menu in WordPress 3.9

[celloexpressions]

Issue in core plugin update details modal.

[celloexpressions]

Thanks for the report, KalleL!

I noticed this same issue with a core modal on one site, but had trouble replicating again. Then I ran into it on another site. The plugin details modal on the updates screen also exhibits the bug (it uses a thickbox).

Specifically, this is an issue when the sticky admin menu is active (menu height is smaller than window height), in that the menu displays above the overlay. It becomes more of an issue at smaller widths when the menu is on top of the modal window. The fix should be a matter of tweaking z-indexes of the modal and the overlay, probably to match those.

This is a 3.9 regression, so it should be considered for 3.9.1.

[iseulde]

Thanks for the reports!
Could someone give me specific steps to reproduce this?
The z-index of the Thickbox modals is 100,050. That of the adminbar and sticky menu are 99,999 and 9,999 respectively.

[celloexpressions]

Looks like this is actually a caching issue. In 3.9 the version string for wp-includes/js/thickbox/thickbox.css is still 20131201, the same as 3.8.

The old file is loading the z-index of 510 instead of the newer value on some of my installs. Refreshing should fix the issue in most browsers, but we should probably bump the version string in the point release to break the browser caching without user intervention, just to be safe.

[nacin]

Let's remove the version string entirely so it uses the WP version as we have beyond forked it at this point.

[celloexpressions]

Remove version from thickbox styles.

[nacin]

In 28176:

Remove version string from Thickbox so it assumes the WP core version. Bust some caches.

props celloexpressions.
see #27861, for trunk.

[nacin]

In 28228:

Rmove version string from Thickbox so it assumes the WP core version. Bust some caches.

Merges [28176] to the 3.9 branch.

props celloexpressions.
fixes #27861.