Theme install return wrong install_url on network admin

[hirizh]

When installing a theme on network admin, the install url is pointing to wp-admin/update.php?action=install-theme instead of wp-admin/network/update.php?action=install-theme. From here, we'll be redirected to the first site dashboard view after the theme installed successfully.

Its not happening with plugins. So I thought its because the ajax call by the themes query. Maybe it relates to #22589.

[ocean90]

Confirmed. Introduced by [28126].

[nacin]

Well, that could have broken in far worse ways. :-)

I think there is a simpler patch for this. 27869.diff​.

network_admin_url() should be used in theme-install.php too (where it is changed in 27869.patch​. self_admin_url() is appropriate for pages that work both inside and outside the network admin even when in multisite (like the plugins list table), while network_admin_url() is good for a page that is network-admin-only in multisite. We probably use self_admin_url() in a few places where network_admin_url() is more appropriate, but you only really notice it in odd situations like this, where admin-ajax.php doesn't have context.

[nacin]

In 28163:

Theme Installer: Proper redirection and action links post-install in multisite.

fixes #27869.

[nacin]

In 28164:

Theme Installer: Proper redirection and action links post-install in multisite.

Merges [28163] to the 3.9 branch.

fixes #27869.