WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#27889 closed defect (bug) (fixed)

"Installed" string is missing a context

Reported by: SergeyBiryukov Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: I18N Keywords: has-patch commit fixed-major i18n-change
Focuses: Cc:
PR Number:

Description

We use _x( 'Installed', 'plugin' ) for plugins and _x( 'Installed', 'theme' ) for themes:
tags/3.9/src/wp-admin/includes/class-wp-plugin-install-list-table.php#L252
tags/3.9/src/wp-admin/includes/class-wp-theme-install-list-table.php#L256

However, one instance (added in [28025]) is missing a context:
tags/3.9/src/wp-admin/theme-install.php#L213

We also need a context for "Already Installed" string, since it's also used in install_blog():
tags/3.9/src/wp-includes/ms-functions.php#L1372

Attachments (1)

27889.patch (989 bytes) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.9.1

This ticket was mentioned in IRC in #wordpress-dev by netweb. View the logs.


6 years ago

#3 @nacin
6 years ago

In 28160:

Use correct echoing context function. see #27889.

#4 @nacin
6 years ago

  • Keywords commit fixed-major i18n-change added

#5 @nacin
6 years ago

  • Milestone changed from 3.9.1 to 3.9.2

#6 @helen
5 years ago

  • Milestone changed from 3.9.2 to 4.0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.