Opened 11 years ago
Closed 8 months ago
#27914 closed defect (bug) (fixed)
Information about image is jumping in media modal
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | ui | Cc: |
Description
When changing title or caption, changes are saved automatically, but information about image is jumping and it is very distracting. It is caused by "Saved." message which is displayed for a sec. See attached screenshots.
Attachments (8)
Change History (31)
#8
@
16 months ago
- Milestone set to 6.5
- Owner set to joedolson
- Status changed from new to accepted
This is still an issue today; but this should be easily resolved.
This ticket was mentioned in Slack in #core-media by antpb. View the logs.
12 months ago
#10
@
12 months ago
Patch changes the heading to display: grid
so the whole area has a defined space. Long headings will wrap, but if there's any page shift (due to a long translation for 'Saved.'), it'll be significantly more subtle.
This ticket was mentioned in Slack in #core-media by joedolson. View the logs.
12 months ago
#13
@
12 months ago
Just echoing what was discussed in the Media Meeting where we reviewed the patch here. It seems that the grid is being respected on my local but still jumping around when the attachment details h2 content is just long enough to not have enough space for the "save" message.
One option mentioned is maybe having a reserved static height area below the h2 for the save message to prevent jumping around. I'm not completely confident that is the right thing to do but it definitely solves the problem more simply.
#14
@
12 months ago
Test Report
Patch Tested: https://core.trac.wordpress.org/attachment/ticket/27914/27914.diff
Environment:
WordPress - 6.5-beta2-57703
OS - Windows
Browser - Chrome
Theme: Twenty Twenty-Four
PHP - 8.1.23
Active Plugin - Test Reports
Actual Results:
- Patch is not working.❌ (Jumping issue is still occurs in Modal)
Attachment:
#15
@
12 months ago
- Keywords needs-refresh added
Since the patch needs more work, are you confident this can be resolved before 6.5 RC 1? This looks like a punt candidate.
#16
@
12 months ago
- Milestone changed from 6.5 to 6.6
I think it makes more sense to punt this for 6.6. It could get finished, but...on the whole, I'd rather not stress myself out over it.
#17
@
9 months ago
This patch provides a little more space for the 'Saved.' text, but also compensates for the loading spinner by positioning it absolutely. Part of what was causing the text shift was that the loading spinner takes up space even when invisible, and the brief window when both the loading spinner and the 'Saved.' confirmation were visible caused the amount of space needed to be greater than the length of either item individually.
Confirmed. This is caused by a long translated string in the header: "Podrobné informace o souboru".
Doesn't happen with a shorter string: 27914.shorter-string.png.