Make WordPress Core

Opened 11 years ago

Last modified 3 weeks ago

#27919 accepted defect (bug)

Similar strings for media modal

Reported by: pavelevap's profile pavelevap Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch
Focuses: administration, ui-copy Cc:

Description

There are some strings which we use for the same action from different modal windows:

  • "Attachment Display Settings" x "Display Settings" - same settings from different windows
  • "Edit Image" x "Edit Original" - same link from different windows
  • "There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

Attachments (1)

27919.diff (4.4 KB) - added by Presskopp 16 months ago.

Download all attachments as: .zip

Change History (22)

#1 @nacin
11 years ago

  • Keywords 4.0-early added
  • Milestone changed from Awaiting Review to Future Release

"There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

That one is a proper change. The other two, however, are by design, as you are editing the *original* attachment, not the particular image, and you're dealing with the particular image's display settings, not the attachment's.

#2 @pavelevap
11 years ago

OK, I understand "Edit Image" x "Edit Original", it makes sense.

But "Display Settings" are a little bit different, I guess. Both strings are related to custom occurence of one attachment. I can set values when inserting or when editing, but still the same action. I would remove word "Attachment" and everybody will still understand what "Display Settings" mean.

#3 @pavelevap
11 years ago

"Align" x "Alignment"?

#4 @pavelevap
11 years ago

There are four strings:

← Cancel Audio Playlist
← Cancel Video Playlist
← Cancel Gallery
Cancel Edit (for image, audio and video files)

1) Cancel Edit is missing ←

2) First 3 strings actually does not cancel anything. It is not possible to cancel gallery by clicking on it, it only closes modal window, gallery is still in editor. So "← Cancel Edit" would be better, I guess.

We could remove 3 strings and use only "← Cancel Edit" for everything. Or we should add also Cancel Video, Cancel Audio and Cancel Image for consistency.

#5 @chriscct7
9 years ago

  • Component changed from I18N to Text Changes
  • Focuses administration added
  • Keywords needs-patch early added; 4.0-early removed

#6 @garrett-eclipse
5 years ago

  • Component changed from Text Changes to Media
  • Focuses ui-copy added

#7 @Presskopp
16 months ago

These points are still valid:

If you ask me, I'd change at least:

There are no associated subtitles ➜ There are no associated tracks
Align ➜ Alignment
← Cancel XY ➜ ← Cancel Edit

@Presskopp
16 months ago

#8 @Presskopp
16 months ago

  • Keywords has-patch added; needs-patch removed

What's missing in the patch is:

label: (0,external_wp_i18n_namespaceObject.)('Align') ➜
label: (0,external_wp_i18n_namespaceObject.
)('Alignment')

in block-editor.js

#9 @joedolson
13 months ago

  • Milestone set to 6.5
  • Owner set to joedolson
  • Status changed from new to accepted

#10 @joedolson
10 months ago

  • Keywords early removed

Ticket doesn't require the 'early' keyword.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


9 months ago

#12 @swissspidy
8 months ago

in block-editor.js

Text changes in that file need to be handled in Gutenberg.

#13 @swissspidy
8 months ago

  • Milestone changed from 6.5 to 6.6

Moving to next milestone as we're approaching RC & string freeze.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


5 months ago

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


5 months ago

#16 @joedolson
5 months ago

  • Milestone changed from 6.6 to 6.7

This is fairly minor, but we just still have to make some decisions, so moving this to 6.7.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 months ago

#18 @antpb
3 months ago

Hello! We had a discussion about this ticket in the Media Meeting and came to some recommendations:

It was discussed that changing "Align" to "Alignment" and "Subtitles" to "tracks" allows better clarity.

For the Cancel buttons, we discussed using "Back" for new playlist/gallery creation, since it's not really cancelling anything. I personally think we could keep "Cancel edit" for editing existing ones that make sense.

It was also discussed removing the left arrows from these buttons and consolidate the cancel strings where we can.

One tricky bit: we'll need some logic to differentiate between creating new items and editing existing ones to show the right button text.

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 months ago

#20 @peterwilsoncc
4 weeks ago

@joedolson Are you able to take a quick look at this and see if it's likely to get in for the 6.7 cycle?

#21 @joedolson
3 weeks ago

  • Milestone changed from 6.7 to 6.8

I don't think this will make it for 6.7. Bumping to 6.8.

Note: See TracTickets for help on using tickets.