Similar strings for media modal

[pavelevap]

There are some strings which we use for the same action from different modal windows:

• "Attachment Display Settings" x "Display Settings" - same settings from different windows

• "Edit Image" x "Edit Original" - same link from different windows

• "There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

[nacin]

"There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

That one is a proper change. The other two, however, are by design, as you are editing the *original* attachment, not the particular image, and you're dealing with the particular image's display settings, not the attachment's.

[pavelevap]

OK, I understand "Edit Image" x "Edit Original", it makes sense.

But "Display Settings" are a little bit different, I guess. Both strings are related to custom occurence of one attachment. I can set values when inserting or when editing, but still the same action. I would remove word "Attachment" and everybody will still understand what "Display Settings" mean.

[pavelevap]

"Align" x "Alignment"?

[pavelevap]

There are four strings:

← Cancel Audio Playlist
← Cancel Video Playlist
← Cancel Gallery
Cancel Edit (for image, audio and video files)

1) Cancel Edit is missing ←

2) First 3 strings actually does not cancel anything. It is not possible to cancel gallery by clicking on it, it only closes modal window, gallery is still in editor. So "← Cancel Edit" would be better, I guess.

We could remove 3 strings and use only "← Cancel Edit" for everything. Or we should add also Cancel Video, Cancel Audio and Cancel Image for consistency.

[Presskopp]

These points are still valid:

If you ask me, I'd change at least:

There are no associated subtitles ➜ There are no associated tracks
Align ➜ Alignment
← Cancel XY ➜ ← Cancel Edit

[Presskopp]

What's missing in the patch is:

label: (0,external_wp_i18n_namespaceObject.)('Align') ➜
label: (0,external_wp_i18n_namespaceObject.)('Alignment')

in block-editor.js