WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 6 months ago

#27919 new defect (bug)

Similar strings for media modal

Reported by: pavelevap Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: Text Changes Keywords: needs-patch early
Focuses: administration Cc:
PR Number:

Description

There are some strings which we use for the same action from different modal windows:

  • "Attachment Display Settings" x "Display Settings" - same settings from different windows
  • "Edit Image" x "Edit Original" - same link from different windows
  • "There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

Change History (5)

#1 @nacin
6 years ago

  • Keywords 4.0-early added
  • Milestone changed from Awaiting Review to Future Release

"There are no associated subtitles." - should be "items", I guess (can be inserted also other things then subtitles).

That one is a proper change. The other two, however, are by design, as you are editing the *original* attachment, not the particular image, and you're dealing with the particular image's display settings, not the attachment's.

#2 @pavelevap
6 years ago

OK, I understand "Edit Image" x "Edit Original", it makes sense.

But "Display Settings" are a little bit different, I guess. Both strings are related to custom occurence of one attachment. I can set values when inserting or when editing, but still the same action. I would remove word "Attachment" and everybody will still understand what "Display Settings" mean.

#3 @pavelevap
6 years ago

"Align" x "Alignment"?

#4 @pavelevap
6 years ago

There are four strings:

← Cancel Audio Playlist
← Cancel Video Playlist
← Cancel Gallery
Cancel Edit (for image, audio and video files)

1) Cancel Edit is missing ←

2) First 3 strings actually does not cancel anything. It is not possible to cancel gallery by clicking on it, it only closes modal window, gallery is still in editor. So "← Cancel Edit" would be better, I guess.

We could remove 3 strings and use only "← Cancel Edit" for everything. Or we should add also Cancel Video, Cancel Audio and Cancel Image for consistency.

#5 @chriscct7
4 years ago

  • Component changed from I18N to Text Changes
  • Focuses administration added
  • Keywords needs-patch early added; 4.0-early removed
Note: See TracTickets for help on using tickets.