WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#27920 closed defect (bug) (fixed)

Default update notification color overrides admin color schemes

Reported by: celloexpressions Owned by: helen
Milestone: 3.9.1 Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords: has-patch fixed-major commit
Focuses: ui Cc:

Description

The update notification bubbles in the admin menu display the default orange background color with every admin color scheme in 3.9.

The issue is that the selector for the default styles is #adminmenu span.update-plugins, while the color schemes use #adminmenu .update-plugins. While neither selector changed in 3.9, the styles did some. This is most likely a bug from the colors.css merge.

Best solution is probably to drop the span from the default styles, although that could cause breakage somewhere I'm missing. Alternatively, adding the span to the color schemes also resolves the issue, although that means regenerating all of the color schemes in what should probably be in a point release.

Attachments (2)

27920.default.diff (409 bytes) - added by celloexpressions 7 years ago.
27920.colors.diff (425 bytes) - added by celloexpressions 7 years ago.

Download all attachments as: .zip

Change History (10)

#1 @celloexpressions
7 years ago

  • Keywords has-patch added

#2 @nacin
7 years ago

  • Milestone changed from Awaiting Review to 3.9.1
  • Owner set to helen
  • Status changed from new to assigned

Looks good, Nick.

#3 @SergeyBiryukov
7 years ago

  • Component changed from General to Administration

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


7 years ago

#5 @helen
7 years ago

I also prefer to simplify selectors where we can, and in testing didn't find any breakage. Rolling with the first patch.

#6 @helen
7 years ago

  • Keywords fixed-major added

[28177] for trunk missed the ticket.

#7 @helen
7 years ago

  • Keywords commit added

#8 @nacin
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 28204:

Simplify the admin menu notification selector so color schemes don't get stomped.

Merges [28177] to the 3.9 branch.

props celloexpressions.
fixes #27920.

Note: See TracTickets for help on using tickets.