Opened 12 years ago
Closed 12 years ago
#27923 closed defect (bug) (fixed)
Playlist track info overflows
| Reported by: | celloexpressions | Owned by: | nacin |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.9.1 |
| Component: | Media | Version: | 3.9 |
| Severity: | normal | Keywords: | has-patch commit fixed-major |
| Cc: | Focuses: | ui |
Description
See screenshots. This was accounted for for the currently playing item details, but not in the tracklist. It needs the addition of display: block or inline-block, and an appropriate max-width.
Attachments (3)
Change History (17)
#1
@
12 years ago
- Keywords has-patch added
This is particularly problematic in scenarios like Twenty Fourteen's Ephemera widgets, and on mobile, where the playlist width is very small. The 40px in the max-width calculation is to leave space for the track duration, which is typically 25-30px but can vary widely. The 88% max-width fallback that's already used for the currently playing view is a sufficient fallback for browsers that don't support calc.
#3
follow-up:
↓ 5
@
12 years ago
I think display: block is sufficient (missed that one...) - there are no other places in core that use calc(...), some themes do, but leaving that out for now.
#5
in reply to: ↑ 3
@
12 years ago
Replying to wonderboymusic:
I think
display: blockis sufficient (missed that one...) - there are no other places in core that usecalc(...)
I've found 3 instances in wp-includes/css/editor.css and one in wp-includes/js/thickbox/thickbox.css.
#7
@
12 years ago
I don't see anything wrong with using calc for things like this - that's what it's designed for and most browsers support it now. In this case it allows as much of the track/artist name to be shown as possible, whereas 88% could leave much less space at large widths (an edge case, of course).
#11
in reply to: ↑ 8
@
12 years ago
Replying to wonderboymusic:
ok, I just try to be conservative so Helen doesn't yell at me
It's appreciated :) We're good here.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Prevent items in track list from overflowing.