WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27924 closed defect (bug) (fixed)

Playlist Media in RTL - conflict with Length Item

Reported by: ariel.k Owned by: nacin
Milestone: 3.9.1 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch commit fixed-major
Focuses: ui, rtl Cc:

Description

Playlist RTL mode there is a problem in view of the length of time the item.
This happens because:
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/mediaelement/wp-mediaelement.css?rev=28158#L137

Attachments (3)

demo_playlist_RTL.png (10.1 KB) - added by ariel.k 6 years ago.
RTL
demo_playlist.png (10.0 KB) - added by ariel.k 6 years ago.
Noraml
27924.patch (712 bytes) - added by SergeyBiryukov 6 years ago.

Download all attachments as: .zip

Change History (10)

@ariel.k
6 years ago

RTL

@ariel.k
6 years ago

Noraml

#1 @wonderboymusic
6 years ago

  • Focuses ui added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.9.1

Thanks ariel.k, investigating now!

#2 @SergeyBiryukov
6 years ago

  • Keywords has-patch added; needs-patch removed

.wp-playlist .wp-playlist-current-item img needs RTL treatment as well.

#3 follow-up: @wonderboymusic
6 years ago

Also, this is happening:

2. “Kill The Horns” — MEGAFAUN

in RTL is:

Kill The Horns” — MEGAFAUN“ .2

#4 in reply to: ↑ 3 @SergeyBiryukov
6 years ago

Replying to wonderboymusic:

Kill The Horns” — MEGAFAUN“ .2

That only happens with English strings, should be OK with a proper RTL title.

#5 @wonderboymusic
6 years ago

In 28173:

Support RTL properly when displaying playlists.

Props SergeyBiryukov.
See #27924.

#6 @wonderboymusic
6 years ago

  • Keywords commit fixed-major added

#7 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28230:

Support RTL properly when displaying playlists.

Merges [28173] to the 3.9 branch.

props SergeyBiryukov.
fixes #27924.

Note: See TracTickets for help on using tickets.