Skip Cropping is not available in Customizer?

[pavelevap]

I can skip cropping image in Custom header admin page, but it is not available in Customizer? Is it "feature" or bug?

[ocean90]

Tested with TwentyFourteen:
I can see the button when the image fits already in the size: ​https://cloudup.com/co5nGzDOde9
Using a 150x150 px image will show the skip button on header screen, but not in the Customizer.

[nacin]

Moving to 3.9.1 for review.

[ocean90]

Related: [22468]/#21100

Logic for the Customizer: tags/3.9/src/wp-admin/js/customize-controls.js#L373​ and tags/3.9/src/wp-includes/js/customize-models.js#L95​

[ocean90]

27936.patch​ is the inversion of tags/3.9/src/wp-admin/custom-header.php#L718​. Based on $oitar (which is 1 otherwise) the skip button is displayed on custom header.

[ehg]

Replying to ocean90:

27936.patch​ is the inversion of tags/3.9/src/wp-admin/custom-header.php#L718​. Based on $oitar (which is 1 otherwise) the skip button is displayed on custom header.

So we're going to allow skipping if the supplied image's width is less than the theme's width?

[ocean90]

Replying to ehg:

So we're going to allow skipping if the supplied image's width is less than the theme's width?

Correct, see ticket:20657:10 and [20806].

[ehg]

Replying to ocean90:

Replying to ehg:

So we're going to allow skipping if the supplied image's width is less than the theme's width?

Correct, see ticket:20657:10 and [20806].

Ok, looks good to me! A test would be nice in https://core.trac.wordpress.org/browser/trunk/tests/qunit/wp-admin/js/customize-header.js - where we're testing all the shouldBeCropped() logic.

[ocean90]

In 28218:

Revert [28217].

Misfired commit for #27936.

[ocean90]

In 28219:

Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.

Add tests.

see #27936 for trunk.

[nacin]

In 28225:

Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.

Merges [28219] to the 3.9 branch.

fixes #27936.