WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27936 closed defect (bug) (fixed)

Skip Cropping is not available in Customizer?

Reported by: pavelevap Owned by: ocean90
Milestone: 3.9.1 Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch commit fixed-major
Focuses: Cc:
PR Number:

Description

I can skip cropping image in Custom header admin page, but it is not available in Customizer? Is it "feature" or bug?

Attachments (2)

27936.patch (395 bytes) - added by ocean90 6 years ago.
27936.2.patch (1.3 KB) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (18)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Appearance

#2 @ocean90
6 years ago

Tested with TwentyFourteen:
I can see the button when the image fits already in the size: https://cloudup.com/co5nGzDOde9
Using a 150x150 px image will show the skip button on header screen, but not in the Customizer.

#3 @nacin
6 years ago

Moving to 3.9.1 for review.

#4 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.9.1

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


6 years ago

This ticket was mentioned in IRC in #wordpress-dev by nacin1. View the logs.


6 years ago

#7 @nacin
6 years ago

  • Owner set to ocean90
  • Status changed from new to assigned

@ocean90
6 years ago

#9 follow-up: @ocean90
6 years ago

  • Keywords has-patch added

27936.patch is the inversion of tags/3.9/src/wp-admin/custom-header.php#L718. Based on $oitar (which is 1 otherwise) the skip button is displayed on custom header.

#10 in reply to: ↑ 9 ; follow-up: @ehg
6 years ago

Replying to ocean90:

27936.patch is the inversion of tags/3.9/src/wp-admin/custom-header.php#L718. Based on $oitar (which is 1 otherwise) the skip button is displayed on custom header.

So we're going to allow skipping if the supplied image's width is less than the theme's width?

#11 in reply to: ↑ 10 ; follow-up: @ocean90
6 years ago

Replying to ehg:

So we're going to allow skipping if the supplied image's width is less than the theme's width?

Correct, see ticket:20657:10 and [20806].

#12 in reply to: ↑ 11 @ehg
6 years ago

Replying to ocean90:

Replying to ehg:

So we're going to allow skipping if the supplied image's width is less than the theme's width?

Correct, see ticket:20657:10 and [20806].

Ok, looks good to me! A test would be nice in https://core.trac.wordpress.org/browser/trunk/tests/qunit/wp-admin/js/customize-header.js - where we're testing all the shouldBeCropped() logic.

@ocean90
6 years ago

#13 @ocean90
6 years ago

In 28218:

Revert [28217].

Misfired commit for #27936.

#14 @ocean90
6 years ago

In 28219:

Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.

Add tests.

see #27936 for trunk.

#15 @ocean90
6 years ago

  • Keywords commit fixed-major added

#16 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 28225:

Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.

Merges [28219] to the 3.9 branch.

fixes #27936.

Note: See TracTickets for help on using tickets.