Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#27945 closed defect (bug) (fixed)

Sortable list table column header text is higher than non-sortable headers

Reported by: helen's profile helen Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.4 Priority: low
Severity: trivial Version: 3.8
Component: Administration Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

See screenshot - it's a not-always-noticeable one pixel difference. Previously: #26131.

Attachments (3)

Screen Shot 2014-04-21 at 2.58.30 AM.png (9.1 KB) - added by helen 10 years ago.
With custom column, which emphasized the issue
27945.patch (317 bytes) - added by drozdz 10 years ago.
Patch
27945-before-after.png (14.2 KB) - added by metodiew 10 years ago.
Before and after

Download all attachments as: .zip

Change History (11)

@helen
10 years ago

With custom column, which emphasized the issue

#1 @helen
10 years ago

  • Keywords needs-patch good-first-bug added

@drozdz
10 years ago

Patch

#2 @drozdz
10 years ago

  • Keywords has-patch added; needs-patch removed

@metodiew
10 years ago

Before and after

#3 @metodiew
10 years ago

It was hard to notice that there is a difference. I tested the patch with Chrome and it works for me.

Last edited 10 years ago by metodiew (previous) (diff)

#4 @DrewAPicture
10 years ago

  • Owner set to drozdz
  • Status changed from new to assigned

#5 @wonderboymusic
9 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner changed from drozdz to wonderboymusic

#6 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34276:

List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.

Props drozdz.
Fixes #27945.

#7 @afercia
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like the increased left and right padding breaks the sort arrow alignment in some tables, see for example the Categories one in the screenshot below:

https://cldup.com/q3ERsTDrGJ.png

#8 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 34892:

List Tables: after [34276], decrease horizontal padding for sorted column headers (causing weirdness in the Count column of tax list tables) - the vertical padding change suffices in fixing the original issue.

Fixes #27945.

Note: See TracTickets for help on using tickets.