When an attachment is edited by another user the sendback url doesn't work

[knutsp]

When an attachment is being edited and another user tries to edit it, the last user is presented with a dialog containing three choices, Media, Preview or Take over.

The Media button takes you to edit.php?post_type=attachment. This page shows an empty list table. The correct page would be upload.php.

[knutsp]

I may try to have a patch ready in a few days.

[johnbillion]

Related: edit.php?post_type=attachment should probably redirect to upload.php.

[DrewAPicture]

Replying to johnbillion:

Related: edit.php?post_type=attachment should probably redirect to upload.php.

If we add the redirect, I'd only request that we take a similar approach to what we did in [25453].

[knutsp]

Replying to johnbillion:

Related: edit.php?post_type=attachment should probably redirect to upload.php.

I agree with this approach. I'm not sure how to patch it this way, so help needed.

[DrewAPicture]

Replying to knutsp:

Replying to johnbillion:

Related: edit.php?post_type=attachment should probably redirect to upload.php.

I agree with this approach. I'm not sure how to patch it this way, so help needed.

Hi knutsp. I'd suggest taking a look at the redirect logic for the 'attachment' post type in post-new.php. You should be able to handle it in basically the same way in edit.php.

[knutsp]

The first paragraph of this ticket's description should read:

When an attachment is being edited by a user, and then has been taken over by another user, the first user is presented with a dialog that informs of this takeover, and contains one button, Media.

[wonderboymusic]

I moved the redirect farther up, but this looks good.

[wonderboymusic]

In 28729:

edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants.

Props knutsp.
Fixes #27951.

[kovshenin]

In r28729, why are we checking the return value of wp_redirect()? It's always true unless it's filtered.

[DrewAPicture]

Replying to kovshenin:

In r28729, why are we checking the return value of wp_redirect()? It's always true unless it's filtered.

I believe that's actually the point of checking -- otherwise we'd exit regardless of whether the filter returns true or false. See also [25453] for context.

[nacin]

I hate what's done in [25453] generally speaking, but there are limited situations where it is not the worst thing in the world. [28729] is one of them.