WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#27956 closed enhancement (fixed)

Move #sidemenu CSS into deprecated-media.css

Reported by: helen Owned by: helen
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords:
Focuses: ui Cc:
PR Number:

Description

We should move #sidemenu CSS into deprecated-media.css, since media-upload.php appears to be the only place remaining using that ID and markup. We can also probably delete some selectors like #sidemenu li a span.update-plugins with a little investigative study.

Attachments (1)

moved-css-27596.diff (1.9 KB) - added by voldemortensen 5 years ago.
moved all #sidemenu references in admin-menu.css to deprecated-media.css

Download all attachments as: .zip

Change History (6)

@voldemortensen
5 years ago

moved all #sidemenu references in admin-menu.css to deprecated-media.css

This ticket was mentioned in IRC in #wordpress-dev by voldemortensen. View the logs.


5 years ago

#2 @helen
5 years ago

  • Milestone changed from Future Release to 4.2

#3 @helen
5 years ago

@voldemortensen: I've got a commit ready to go, but for future reference, the other selectors in your patch needed to stay put and there were some more instances of #sidemenu :)

#4 @helen
5 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 31564:

CSS: Move relevant #sidemenu rules into deprecated-media.css and remove the cruft.

fixes #27956.

#5 @voldemortensen
5 years ago

@helen: Yeah, I think this was the first patch I ever submitted. :) If not, close to it. Thanks for the heads up.

Note: See TracTickets for help on using tickets.