WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 3 months ago

#27957 new enhancement

Revisit the Tag/Category Converter mention on the Tools Page

Reported by: MadtownLems Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: General Keywords: needs-patch
Focuses: ui, administration Cc:

Description

Core's tools.php page specifically calls attention to the "Categories and Tags Converter" plugin.

I'd suggest eliminating reference to this completely.

It looks to be a relic from years ago that just kind of came along for the ride, and doesn't really have a place in modern Core. I think it's a perfect example of functionality that falls into 'Plugin Territory' - which, luckily, is how it's currently implemented. There are also a large number of similar, more well-maintained plugins that can accomplish this and more for a larger number of taxonomies.

If it's decided that the reference should stay, then I believe the logic surrounding the output needs to be modified, more along the lines of this psuedocode:

(As currently, if a user can Manage Terms, they're instructed to go install a plugin, even if they may lack that capability.)

	

    if ( current_user_can($cats->cap->manage_terms) || current_user_can($tags->cap->manage_terms) ) {
     
            if ( $tag_category_converter_is_installed //TODO: this check ) {
                    // provide link for actually using it. TODO: this link
            } else {
                    if ( current_user_can( 'install_plugins') ) {
                    ?>
                    <div class="tool-box">
                            <h3 class="title"><?php _e( 'Categories and Tags Converter' ) ?></h3>
                            <p><?php printf( __('If you want to convert your categories to tags (or vice versa), use the <a href="%s">Categories and Tags Converter</a> available from the Import screen.'), 'import.php' ); ?></p>
                    </div>
                    <?php
                    }
            }
    }


Attachments (2)

27957.patch (2.2 KB) - added by MadtownLems 5 years ago.
Basic removal of text and contextual help tab
27957-2.patch (2.2 KB) - added by MadtownLems 5 years ago.
Patch generated from root (per request)

Download all attachments as: .zip

Change History (8)

@MadtownLems
5 years ago

Basic removal of text and contextual help tab

This ticket was mentioned in IRC in #wordpress-dev by MadLems. View the logs.


5 years ago

@MadtownLems
5 years ago

Patch generated from root (per request)

#2 @georgestephanis
5 years ago

It looks like it's still getting about 150 downloads per day or so according to http://wordpress.org/plugins/wpcat2tag-importer/stats/ and I wonder what the general consensus is, whether removing that helper text would increase support volume.

#4 @DrewAPicture
5 years ago

I'm actually in the process of working on a re-think POC of the Tools screen, including our handling of things like the Categories & Tags convertor. I'll post back when I have something coherent :-)

#5 @netweb
5 years ago

The 'importers' including 'cat2tag' used to be in core and were removed/moved to plugins for WP 3.0 in #13465

So it's not so much 'advertising' the 'cat2tag' plugin in WP's admin tools, it was linked in tools so that back compat was not broken for those who used the tool regularly (myself included, back in the day) in that there was a quick and easy method to get the feature back easily via plugin install.

As for an opinion on if this should now be removed, I'd say yes, remove it. Back compat is still not broken.

I'd also suggest adding some 'top level' text (and help text) to the /wp-admin/tools.php page above the 'Press This' with some generalised text on what the 'Tools' section of the dashboard is all about including links to /wp-admin/import.php and /wp-admin/export.php with summary descriptions. This is what I think @DrewAPicture is alluding to above, a better T.O.C for the tools page.

#6 @chriscct7
4 years ago

  • Keywords needs-patch added

@DrewAPicture Do you want to adopt this?

Note: See TracTickets for help on using tickets.