WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#27963 closed defect (bug) (fixed)

If the editor's "Toolbar toggle" button is removed, the second toolbar row may remain hidden

Reported by: azaozz Owned by: nacin
Milestone: 3.9.1 Priority: normal
Severity: minor Version: 3.9
Component: TinyMCE Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

In 3.8 there was a setting wordpress_adv_hidden that was used for the initial state of the toggle, but could also be used to always show the second row.

Attachments (1)

27963.patch (576 bytes) - added by azaozz 5 years ago.

Download all attachments as: .zip

Change History (9)

@azaozz
5 years ago

#1 @azaozz
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.9.1

27963.patch restores the 3.8 behavior. Moving to 3.9.1 for consideration.

#2 @ocean90
5 years ago

#27969 was marked as a duplicate.

#3 @josh401
5 years ago

27963.patch works for me. Perfect.
I vote it stays :)

Thank you, Mr. Ozz!!

EDIT: And just to clarify, in TinyMCE4 the force open of the 'toggle toolbars' will show ALL rows by default (that have active buttons).. not just the second row.

Last edited 5 years ago by josh401 (previous) (diff)

#4 follow-up: @nacin
5 years ago

  • Keywords commit added

Logic seems good to me.

#5 @nacin
5 years ago

In 28181:

TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink.

props azaozz.
see #27963, for trunk.

#6 @nacin
5 years ago

  • Keywords fixed-major added

#7 in reply to: ↑ 4 @josh401
5 years ago

Replying to nacin:

Logic seems good to me.

Yep. The old TinymMCE3 kitchen sink button would only expand/collapse row 2 of the editor buttons. So, if we hooked or filtered in buttons to row 3 or 4.. they would still be visible with the kitchen sink in it's collapsed (closed) state.

The new TinyMCE4 toggle toolbars button is much more logical in the fact that it now collapses all rows.. leaving just the top row visible. Much better.

Thanks guys!

#8 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28226:

TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink.

Merges [28181] to the 3.9 branch.

props azaozz.
fixes #27963.

Note: See TracTickets for help on using tickets.