pauseAllPlayers in media-audiovidio.js stops players on the entire page

[raptor235]

The issue is that players outside of the tinymce get stopped... the function should target the players within the tinymce editor only and don't stop all players on the page weather they're related to the switching between rich text and html mode...

$(document.body)

.on( 'click', '.wp-switch-editor', wp.media.mixin.pauseAllPlayers )

pauseAllPlayers: function() {

var p;
if ( window.mejs && window.mejs.players ) {

for ( p in window.mejs.players ) {

window.mejs.players[p].pause();

}

}

},

[wonderboymusic]

In what case would you be editing media and want players to be continuously playing on your site? The players need to be paused because they will be removed when the context changes anyways.

Even if we were to specify the context of body as body.wp-admin or something, the editor and media modal could be loaded on the front end, and we would still want to pause the players when editing and switching contexts.

I have been trying to think of a good scenario where this would be problematic, please let me know if I am missing somehthing

[raptor235]

Hi so we run the company called Sidekick... which is a help/tutorial system within WordPress wordpress.org/plugins/sidekick ... we have an audio player that guides the user through specific scenarios so they can learn WordPress.

The player is within the body under our own div... so when we're trying to teach users about tinymce and have the users switch the tabs... our entire walkthrough experience get's stopped because all media players get stopped... even though our player on the page has nothing to do with the tinymce editor being switched to html mode... this is the scenario we're facing right now... but anyone else that might have a media or audio player playing would get stopped on the page because the tinymce editor is switching... I would suggest that only media players within the actual tinymce editor get stopped not everything on the page...

Bart

[wonderboymusic]

27971.diff​ fixes this by only pausing the players attached to objects. Your use case is unique, but incredibly valid.

[wonderboymusic]

In 28364:

When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.

Fixes #27971.

[iseulde]

I don't like the click listener on .wp-switch-editor. Switching the editor can also be triggered manually with switchEditors.go(). Instead I would pause the played when the tinymce editor hides. Patch attached.

[iseulde]

I knew we'd need that editor variable at some point. ;)

[wonderboymusic]

In 28784:

Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view.

Props avryl.
Fixes #27971.