WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #27982, comment 9


Ignore:
Timestamp:
07/27/2014 10:54:58 AM (6 years ago)
Author:
michalzuber
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27982, comment 9

    initial v1  
    1 Couldn't find boolean result source, worth mentioning I'm not a C guru :)
    2 Looked at:
    3 * [https://github.com/php/php-src/blob/2f1148ae8a09cf7644255c31162819d04285bab2/ext/mysqli/mysqli_nonapi.c#L509 ext/mysqli/mysqli_nonapi.c#L509]
    4 * [https://github.com/php/php-src/blob/5d6805d4982999bd302b13dbe6052e10de7f9db2/ext/mysqli/mysqli.c#L1236 ext/mysqli/mysqli.c#L1236]
    5 * [https://github.com/php/php-src/blob/a5f5855db9e0e413e5a2ab221e7e11cc5ee03037/ext/mysqli/php_mysqli_structs.h#L254 ext/mysqli/php_mysqli_structs.h#L254]
    6 
    7 According to me from PHP source it shouldn't return boolean only if it's array
    8 {{{if (into_object && Z_TYPE_P(return_value) == IS_ARRAY)}}} [https://github.com/php/php-src/blob/5d6805d4982999bd302b13dbe6052e10de7f9db2/ext/mysqli/mysqli.c#L1285 ext/mysqli/mysqli.c#L1285]
    9 
    101Checked why might {{{mysql_fetch_object}}} be error suppressed [https://github.com/WordPress/WordPress/blame/master/wp-includes/wp-db.php#L1617 wp-includes/wp-db.php#L1617] and
    112found that the initial class author https://github.com/WordPress/WordPress/blob/43e4a8a930be8b3d0359e517e4a6ef12f0d0ba73/wp-includes/wp-db.php#L203 had it.
    123
    13 Yeah, I'm aware that the following isn't the "nicest", but better then it is:
     4Yeah, I'm aware that the following isn't the "nicest", but should be better then it is:
    145{{{
    156if ( $this->use_mysqli ) {