WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#27988 closed defect (bug) (fixed)

wrong string in core

Reported by: jnhghy Owned by: nacin
Milestone: 4.0 Priority: lowest
Severity: minor Version: 4.0
Component: Editor Keywords: needs-patch
Focuses: docs Cc:

Description

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-editor.php#L947
the text there says that copy paste command is "CTRL + X/C/V/" which actually is "CTRL + x/c/v"

an upper case X or C or V means ctrl+shift+v when in fact the copy/paste/cut command don't use shift key.

Attachments (1)

27988.patch (1.5 KB) - added by ebinnion 5 years ago.
Patch for ticket #27988

Download all attachments as: .zip

Change History (11)

#1 @johnbillion
5 years ago

  • Keywords needs-patch added
  • Priority changed from normal to lowest

Additionally, these commands are incorrect if you're on a Mac. We should either remove the references to the keyboard shortcuts altogether, or put some logic in there to display ctrl or cmd depending on OS.

#2 @jnhghy
5 years ago

  • Severity changed from normal to minor

#3 @iseulde
5 years ago

Note that capitals are usually used for readability. The letters on your keyboard are capitals as well, even though they produce lower case letters without shift.

#4 @iseulde
5 years ago

That said, we should make all these strings consistent. Currently both are used.

@ebinnion
5 years ago

Patch for ticket #27988

#5 @ebinnion
5 years ago

After talking to Nacin at WordCamp Austin contributor day, he suggested that we change the prompt to read 'Please use the edit menu or keyboard shortcuts instead.'

The above patch changes this.

#6 @nacin
5 years ago

Modified the string a bit further based on feedback from siobhan on ambiguity.

#7 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 4.0

#8 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28220:

Improve TinyMCE string for paste command browser support.

props ebinnion.
fixes #27988.

#9 @DrewAPicture
5 years ago

  • Focuses docs added

#10 @pavelevap
5 years ago

Any idea where can be seen this string in editor? I did not notice it anywhere...

Note: See TracTickets for help on using tickets.