Context Navigation

← Previous Ticket
Next Ticket →

#27988 closed defect (bug) (fixed)

wrong string in core

Reported by:	jnhghy	Owned by:	nacin
Priority:	lowest	Milestone:	4.0
Component:	Editor	Version:	4.0
Severity:	minor	Keywords:	needs-patch
Cc:		Focuses:	docs

Description

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-editor.php#L947
the text there says that copy paste command is "CTRL + X/C/V/" which actually is "CTRL + x/c/v"

an upper case X or C or V means ctrl+shift+v when in fact the copy/paste/cut command don't use shift key.

Attachments (1)

27988.patch (1.5 KB ) - added by ebinnion 12 years ago.: Patch for ticket #27988

Download all attachments as: .zip

Change History (11)

#1 @johnbillion
12 years ago

Keywords needs-patch added
Priority normal → lowest

Additionally, these commands are incorrect if you're on a Mac. We should either remove the references to the keyboard shortcuts altogether, or put some logic in there to display ctrl or cmd depending on OS.

#2 @jnhghy
12 years ago

Severity normal → minor

#3 @iseulde
12 years ago

Note that capitals are usually used for readability. The letters on your keyboard are capitals as well, even though they produce lower case letters without shift.

#4 @iseulde
12 years ago

That said, we should make all these strings consistent. Currently both are used.

@ebinnion
12 years ago

Attachment 27988.patch added

Patch for ticket #27988

#5 @ebinnion
12 years ago

After talking to Nacin at WordCamp Austin contributor day, he suggested that we change the prompt to read 'Please use the edit menu or keyboard shortcuts instead.'

The above patch changes this.

#6 @nacin
12 years ago

Modified the string a bit further based on feedback from siobhan on ambiguity.

#7 @nacin
12 years ago

Milestone Awaiting Review → 4.0

#8 @nacin
12 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

In 28220:

Improve TinyMCE string for paste command browser support.

props ebinnion.
fixes #27988.

#9 @DrewAPicture
12 years ago

Focuses docs added

#10 @pavelevap
12 years ago

Any idea where can be seen this string in editor? I did not notice it anywhere...

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#27988 closed defect (bug) (fixed)

wrong string in core

Description

Attachments (1)

Change History (11)

#1 @johnbillion 12 years ago

#2 @jnhghy 12 years ago

#3 @iseulde 12 years ago

#4 @iseulde 12 years ago

@ebinnion 12 years ago

#5 @ebinnion 12 years ago

#6 @nacin 12 years ago

#7 @nacin 12 years ago

#8 @nacin 12 years ago

#9 @DrewAPicture 12 years ago

#10 @pavelevap 12 years ago