WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#27992 closed defect (bug) (fixed)

Theme Customizer doesn't load content when activated from a 404 page.

Reported by: kwight Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Go to any page that produces a 404, and select the Customizer from the admin bar. The Customizer sidebar loads, but no content, leaving just the grey overlay (because of the 404).

I would expect it to load the same page I was looking at anyways – the 404 template.

Attachments (1)

27992.diff (1.1 KB) - added by westonruter 4 years ago.
Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead. Also pushed to GitHub: https://github.com/x-team/wordpress-develop/pull/19

Download all attachments as: .zip

Change History (7)

@westonruter
4 years ago

Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead. Also pushed to GitHub: https://github.com/x-team/wordpress-develop/pull/19

#1 @westonruter
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.0
  • Owner set to ocean90
  • Status changed from new to reviewing

#2 @westonruter
4 years ago

  • Milestone 4.0 deleted
  • Status changed from reviewing to closed
  • Version changed from trunk to 3.4

#3 @westonruter
4 years ago

  • Milestone set to 4.0
  • Status changed from closed to reopened

#4 @westonruter
4 years ago

  • Status changed from reopened to reviewing

#5 @westonruter
4 years ago

  • Keywords commit added

#6 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 28970:

Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead.

props westonruter.
fixes #27992.

Note: See TracTickets for help on using tickets.