Logic for custom header default text color is broken

[ocean90]

Have a theme which registers following header support:

add_theme_support( 'custom-header', array(
	'width'       => 500,
	'flex-height' => true,
	'height'      => 500,
) );

(Or use Twenty Eleven and remove 'default-text-color' => '000',.)

Then go to Appearance > Header. You will see that beside "Text color" is nothing (see attached screenshot). Unchecking the checkbox for "Header Text" will produce a JS error: Uncaught TypeError: Cannot read property 'replace' of undefined in themes.php?page=custom-header:61.

The issue is that current_theme_supports( 'custom-header', 'default-text-color' ) returns false.

My original goal was to just support custom header images and allow to show/hide the header text. No color changing. Per default header-text will be true. default-text-color is an empty string. But that seems impossible with our API yet.

[ocean90]

28042.patch​ moves the input field out of the current_theme_supports() check.

[ocean90]

[22695] / #22461

[obenland]

With 28042.patch​ we'd still be missing a default value.

Can we assume that if a theme does not provide a default color, it does not support changing the header color and that setting should not even appear?
Or do we consider changing the color a core feature that should work regardless of what the theme set its default to be?
Judging from how add_theme_support() sets the defaults, it's currently the former.

[ocean90]

Replying to obenland:

With 28042.patch​ we'd still be missing a default value.

The default value is an empty string, see tags/3.9/src/wp-includes/theme.php#L1453​

Can we assume that if a theme does not provide a default color, it does not support changing the header color and that setting should not even appear?

No. Maybe we can use a value of false to disable the color feature, but that's another ticket.

Or do we consider changing the color a core feature that should work regardless of what the theme set its default to be?

Which is the current behavior, at least for the Customizer, but broken on the Custom Header screen.

[obenland]

I see. I wasn't aware Iris reverted to Clear instead of Default when no default value is present. I assumed it always needed a default.

With your patch we'd still be left with a stray # in the input field, which is not present in the customizer. I think #27583 would come in really handy here.

[ocean90]

28042.2.patch​ removes the stray # from the input field.

[ocean90]

In 28294:

Custom Header: Fix logic when a theme doesn't set default-text-color.

fixes #28042.