Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#28048 closed defect (bug) (fixed)

Twenty Fourteen: Align center in editor doesn't work with HTML5 captions implemented

Reported by: RDall Owned by: SergeyBiryukov
Priority: normal Milestone: 4.0
Component: Bundled Theme Version: 3.9
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

I found this in a theme I was creating thinking it was my own code, but a fresh rebase of trunk on a different build and I found exactly the same issue in twenty fourteen.

How to create the bug.

  1. Edit post.
  1. Add Image with caption.
  1. Add a paragraph of text below to show image float properly.


  • Click align left the image floats left, text wraps around right.
  • Click align right and the image floats right, text wraps around left.
  • Click align centre and the image doesn't move. But if you preview save and preview the front end it will centre the image. 

You can also view this screencast. http://cl.ly/3N3d3n40121l

Attachments (2)

28048.png (18.4 KB ) - added by SergeyBiryukov 12 years ago.
28048.patch (383 bytes ) - added by RDall 12 years ago.
Fixes align center in admin for html5 captions

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in IRC in #wordpress-dev by RDall. View the logs.


12 years ago

#2 @RDall
12 years ago

  • Resolutioninvalid
  • Status newclosed

@SergeyBiryukov
12 years ago

#3 @SergeyBiryukov
12 years ago

  • Keywords needs-patch added
  • Milestone Awaiting ReviewFuture Release
  • Resolution invalid
  • Status closedreopened
  • Version trunk3.9

I can still reproduce the issue in Chrome in both 3.9 and current trunk. Could not reproduce in Firefox.

I also see a weird delay when changing the alignment in both Chrome and Firefox.

On the screenshot above, "Align right" button is clicked, but "Align center" button is still highlighted, and the selection still stays on the left.

In a few seconds (5 to 10), the selection moves to the right, and the corresponding button gets highlighted.

#4 @RDall
12 years ago

Thanks for confirming this serge I though it was actually just some weird one off.

This ticket was mentioned in IRC in #wordpress-dev by RDall. View the logs.


12 years ago

@RDall
12 years ago

Fixes align center in admin for html5 captions

#6 @RDall
12 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#7 follow-up: @SergeyBiryukov
12 years ago

  • Component EditorBundled Theme
  • Keywords commit added; needs-testing removed
  • Milestone Future Release4.0
  • Summary align center in editor doesn't work with HTML5 captions implementedTwenty Fourteen: Align center in editor doesn't work with HTML5 captions implemented

28048.patch works for me.

There's still some delay mentioned in comment:3, but that would be a separate ticket.

#9 @SergeyBiryukov
12 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status reopenedclosed

In 28941:

Twenty Fourteen: Fix display of center-aligned images with captions in TinyMCE.

props RDall.
fixes #28048.

#10 in reply to: ↑ 7 @SergeyBiryukov
12 years ago

Replying to SergeyBiryukov:

There's still some delay mentioned in comment:3, but that would be a separate ticket.

Follow-up: #28705

Note: See TracTickets for help on using tickets.