WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28048 closed defect (bug) (fixed)

Twenty Fourteen: Align center in editor doesn't work with HTML5 captions implemented

Reported by: rdall's profile RDall Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

I found this in a theme I was creating thinking it was my own code, but a fresh rebase of trunk on a different build and I found exactly the same issue in twenty fourteen.

How to create the bug.

  1. Edit post.
  1. Add Image with caption.
  1. Add a paragraph of text below to show image float properly.


  • Click align left the image floats left, text wraps around right.
  • Click align right and the image floats right, text wraps around left.
  • Click align centre and the image doesn't move. But if you preview save and preview the front end it will centre the image. 

You can also view this screencast. ​http://cl.ly/3N3d3n40121l

Attachments (2)

28048.png​ (18.4 KB) - added by SergeyBiryukov 10 years ago.
28048.patch​ (383 bytes) - added by RDall 10 years ago.
Fixes align center in admin for html5 captions

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in IRC in #wordpress-dev by RDall. ​View the logs.
10 years ago

#2 @RDall
10 years ago

  • Resolution set to invalid
  • Status changed from new to closed

@SergeyBiryukov
10 years ago

#3 @SergeyBiryukov
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version changed from trunk to 3.9

I can still reproduce the issue in Chrome in both 3.9 and current trunk. Could not reproduce in Firefox.

I also see a weird delay when changing the alignment in both Chrome and Firefox.

On the screenshot above, "Align right" button is clicked, but "Align center" button is still highlighted, and the selection still stays on the left.

In a few seconds (5 to 10), the selection moves to the right, and the corresponding button gets highlighted.

#4 @RDall
10 years ago

Thanks for confirming this serge I though it was actually just some weird one off.

This ticket was mentioned in IRC in #wordpress-dev by RDall. ​View the logs.
10 years ago

@RDall
10 years ago

Fixes align center in admin for html5 captions

#6 @RDall
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#7 follow-up: @SergeyBiryukov
10 years ago

  • Component changed from Editor to Bundled Theme
  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 4.0
  • Summary changed from align center in editor doesn't work with HTML5 captions implemented to Twenty Fourteen: Align center in editor doesn't work with HTML5 captions implemented

28048.patch​ works for me.

There's still some delay mentioned in comment:3, but that would be a separate ticket.

#9 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from reopened to closed

In 28941:

Twenty Fourteen: Fix display of center-aligned images with captions in TinyMCE.

props RDall.
fixes #28048.

#10 in reply to: ↑ 7 @SergeyBiryukov
10 years ago

Replying to SergeyBiryukov:

There's still some delay mentioned in comment:3, but that would be a separate ticket.

Follow-up: #28705

Note: See TracTickets for help on using tickets.