Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#28051 closed defect (bug) (wontfix)

Login action url doesn't follow filtered URL in wp_login_form

Reported by: tareq1988's profile tareq1988 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: Login and Registration Keywords:
Focuses: template Cc:

Description

As someone can change the login url from wp-login.php to something else via a filter, the changed url doesn't take effect on wp_login_form yet. It always uses wp-login.php and I think the URL should also be changed if someone is altering the url via login_url filter.

Attachments (1)

login-form-urlfix.28051.diff (2.0 KB) - added by tareq1988 12 years ago.
fixes the issue

Download all attachments as: .zip

Change History (4)

@tareq1988
12 years ago

fixes the issue

#1 @SergeyBiryukov
12 years ago

  • Component changed from General to Login and Registration
  • Version changed from trunk to 3.9

Same instance in wp-login.php: tags/3.9/src/wp-login.php#L858.

Note that we use login_post scheme here, and wp_login_url() uses login:
tags/3.9/src/wp-includes/general-template.php#L349.

So this doesn't look like an oversight, more like a conscious decision to keep wp-login.php as the form handler.

#2 @tareq1988
12 years ago

I've searched through the codebase and only thing I can see, it uses to determine whether to use SSL or not. In this case login context and it also applies for SSL. Why the context is necessary I don't know yet, but changing the login url is also necessary.

#3 @nacin
12 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

This is designed to be posted to wp-login.php as that is what is actually doing the authentication.

Note: See TracTickets for help on using tickets.