WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#28062 closed defect (bug) (fixed)

.wp-pointer-right is broken for normal LTR

Reported by: georgestephanis Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: minor Version: 3.9
Component: Help/About Keywords: has-patch commit
Focuses: ui, rtl Cc:
PR Number:

Description

It looks like [28107] and #27778 actually broke .wp-pointer-right for normal LTR --

https://i.cloudup.com/7xng_FG6KB.png

If I switch it back to 14px, it looks correct. Have not tested it against RTL, though, merely speaking for pointer-right in LTR.

https://i.cloudup.com/QNIAzasT4Z.png

Attachments (3)

28062.patch (3.1 KB) - added by SergeyBiryukov 5 years ago.
28062.wp350-media.png (7.9 KB) - added by SergeyBiryukov 5 years ago.
28062.wp390-widgets.png (28.5 KB) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (7)

#1 @wonderboymusic
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0

#2 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28877:

Fix the spacing between the wp-pointer arrow and bubble in LTR and RTL.

Fixes #28062.

#3 @SergeyBiryukov
5 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[28877] fixed .wp-pointer-right, but broke .wp-pointer-left in the same way: 28062.wp350-media.png.

I've also noticed that .wp-pointer-bottom is currently misplaced: 28062.wp390-widgets.png (that pointer is actually .wp-pointer-left, I've just changed it to .wp-pointer-bottom to illustrate the issue).

28062.patch fixes positioning issues for all kinds of pointers, for both LTR and RTL.

#4 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 28897:

Fix feature pointer positioning issues for both LTR and RTL.

fixes #28062.

Note: See TracTickets for help on using tickets.