WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 6 years ago

#28089 closed defect (bug) (fixed)

wpviews: gallery template should not include caption tags when there is no caption

Reported by: iseulde's profile iseulde Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: Gallery Keywords: has-patch
Focuses: Cc:

Description

In the gallery shortcode, caption tags are also not included if there is no caption.
In Twenty Thirteen, this will give you an empty black area at the bottom of the image. See attached screenshot.

I'm not sure to which component this belongs. TinyMCE (wpviews), Editor or Media?

Attachments (2)

Screen Shot 2014-05-01 at 08.30.46.png​ (53.0 KB) - added by iseulde 11 years ago.
28089.patch​ (684 bytes) - added by iseulde 11 years ago.

Download all attachments as: .zip

Change History (11)

@iseulde
11 years ago

@iseulde
11 years ago

#1 @iseulde
11 years ago

  • Keywords has-patch added

#2 @iseulde
11 years ago

  • Component changed from Media to Gallery

#4 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 4.0

#5 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28442:

Don't include caption tags in gallery template when there is no caption.

props avryl.
fixes #28089.

#6 @azaozz
11 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This throws an exception in IE < 9. 'string'.trim() is ​not available there and doesn't seem needed.

Last edited 11 years ago by azaozz (previous) (diff)

#7 @azaozz
11 years ago

In 28683:

Fix JS error in tmpl-editor-gallery, 'string'.trim() is not available in IE < 9. See #28089

#8 @azaozz
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [28683].

This ticket was mentioned in ​Slack in #core by pento. ​View the logs.
6 years ago

Note: See TracTickets for help on using tickets.