WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 4 months ago

#28117 new defect (bug)

Admin bar shouldn't use dynamic styles on frontend for logged out visitors

Reported by: dimadin Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: administration Cc:
PR Number:

Description

Admin bar gets styles depending on current user's browser. Problem is that when you using admin bar on front end for logged out users with full page cache turned on, visitor with IE or mobile might be the first one so everyone else with get that specific style.

See #26221 for similar problem.

Attachments (1)

28117.patch (1.1 KB) - added by dimadin 5 years ago.

Download all attachments as: .zip

Change History (8)

@dimadin
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.0

#2 @toscho
5 years ago

That’s a general problem in WordPress: a header Vary: User-Agent is never set when the output depends on the user agent.

#3 @obenland
5 years ago

  • Keywords has-patch added
  • Version set to 3.3

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


5 years ago

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


5 years ago

#6 @DrewAPicture
5 years ago

  • Milestone changed from 4.0 to Future Release

As this is not a regression, let's take a look at this in 4.1. Punting.

#7 @chriscct7
4 years ago

  • Focuses administration added
Note: See TracTickets for help on using tickets.