Theme Feature Filter problem with Warnings

[pavelevap]

There are several Warnings:

Warning: Illegal offset type in isset or empty in C:\www\wordpress\src\wp-admin\includes\theme.php on line 269

Warning: Illegal offset type in C:\www\wordpress\src\wp-admin\includes\theme.php on line 272

Using latest xampp, Windows, I am not sure if it is not somehow related to .org API?

Related topic: ​http://wordpress.org/support/topic/after-installation-of-wperror-occurs-in-appearance-themes-feature-filter (and many others).

[SergeyBiryukov]

Confirmed.

See the relevant block in get_theme_featured_list(): tags/3.9/src/wp-admin/includes/theme.php#L261​.

$feature_items used to be a simple array, and now it contains a nested array:

Array(
	[name] => Colors
	[items] => Array(
		[black] => black
		[blue] => blue
		[brown] => brown
		[gray] => gray
		[green] => green
		[orange] => orange
		[pink] => pink
		[purple] => purple
		[red] => red
		[silver] => silver
		[tan] => tan
		[white] => white
		[yellow] => yellow
		[dark] => dark
		[light] => light
	)
)

28121.patch​ fixes this, but it's also broken in 3.8.3 and all previous versions, so this looks like an accidental change on the WordPress.org API side that should be reverted.

Moving to 3.9.2 for tracking.

[SergeyBiryukov]

To be clear, it's not just the warnings, the feature filter is currently unusable (see the screenshot).

[Otto42]

This was caused by some changes to the themes directory for I18N reasons. Looking into how to properly revert this change now.

cc @iandunn

[Otto42]

API changes reverted. The intended changes will have to be redone in a different way.

The API response should not have been changed at all, so the core patch is not necessary at this time.

[iandunn]

This was my fault, sorry about that :|

I attached some unit tests that would have caught the mistake.

[wonderboymusic]

We should commit these tests in the external http group and then close this ticket.

[SergeyBiryukov]

In 39906:

Themes: Add a unit test for get_theme_feature_list() to make sure that the list of theme features pulled from the WordPress.org API returns the expected data structure.

Props iandunn.
Fixes #28121.