![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 12 years ago
Closed 10 years ago
#28121 closed enhancement (fixed)
Theme Feature Filter problem with Warnings
| Reported by: | pavelevap | Owned by: | jorbin |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Themes | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
There are several Warnings:
Warning: Illegal offset type in isset or empty in C:\www\wordpress\src\wp-admin\includes\theme.php on line 269 Warning: Illegal offset type in C:\www\wordpress\src\wp-admin\includes\theme.php on line 272
Using latest xampp, Windows, I am not sure if it is not somehow related to .org API?
Related topic: http://wordpress.org/support/topic/after-installation-of-wperror-occurs-in-appearance-themes-feature-filter (and many others).
Attachments (3)
Change History (14)
#1
@
12 years ago
- Milestone Awaiting Review → 3.9.2
- Priority normal → highest omg bbq
- Severity normal → critical
#2
@
12 years ago
To be clear, it's not just the warnings, the feature filter is currently unusable (see the screenshot).
#3
@
12 years ago
This was caused by some changes to the themes directory for I18N reasons. Looking into how to properly revert this change now.
cc @iandunn
#4
@
12 years ago
- Resolution → fixed
- Status new → closed
API changes reverted. The intended changes will have to be redone in a different way.
The API response should not have been changed at all, so the core patch is not necessary at this time.
#6
@
12 years ago
- Resolution fixed
- Status closed → reopened
This was my fault, sorry about that :|
I attached some unit tests that would have caught the mistake.
#7
@
12 years ago
- Keywords has-patch added
- Milestone WordPress.org → Awaiting Review
- Priority highest omg bbq → normal
- Severity critical → normal
- Type defect (bug) → enhancement
#8
@
11 years ago
- Owner set to
- Status reopened → assigned
We should commit these tests in the external http group and then close this ticket.
Confirmed.
See the relevant block in
get_theme_featured_list(): tags/3.9/src/wp-admin/includes/theme.php#L261.$feature_itemsused to be a simlpe array, and now it contains a nested array:28121.patch fixes this, but it's also broken in 3.8.3 and all previous versions, so this looks like an accidental change on the WordPress.org API side that should be reverted.
Moving to 3.9.2 for tracking.