Duplicate strings for tabs in theme install page

[pavelevap]

There are several duplicate strings, for example:

• "Featured" with context "Theme Installer"

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php#L44

• "Featured" with context "themes"

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/theme-install.php#L123

But it is the same context. We do not need several duplicate strings. I am not sure if older strings are needed in new redesign of install page? But we should use the same context and combine strings, I guess.

[SergeyBiryukov]

WP_Theme_Install_List_Table is no longer used, but yes, we should use a consistent context.

[pavelevap]

I can make a patch, but I am not sure if only combine context or there will be some code cleanup changes (removing not used parts).

[SergeyBiryukov]

Let's just combine the context for now.

[pavelevap]

OK, thank you! I tried to combine strings and as a result 4 strings can be removed.

• "Fetured" (same strings with different context).

• Changed "Latest" to "Newest" (combine strings and respect also Plugin Installer)

• Combined "Upload" and "Upload Theme" (same meaning).

• Commented "Recenty Updated" (not used and needed).

I am not sure about all these changes, so please look at it.

[SergeyBiryukov]

I'd suggest using the newer context, 'themes': 28123.patch​.

It would still allow us to remove 3 strings. 'Recently Updated' is indeed unused, but I think we should keep it until the whole WP_Theme_Install_List_Table class is removed.

[pavelevap]

No problem :-) Only 2 strings ("Featured" and "Latest") will be removed when "Upload" and "Upload Theme" will not be merged.

[SergeyBiryukov]

In 28287:

Use a consistent context to remove duplicate strings.

props pavelevap.
fixes #28123.