Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28148 closed defect (bug) (fixed)

Small theme ratings glitch for localized versions

Reported by: pavelevap's profile pavelevap Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: low
Severity: minor Version: 3.9
Component: Themes Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

Can we have number of ratings related string bellow stars (as for plugins)? When there are many ratings, localized version is not looking good). See attached screenshot.

Attachments (6)

Theme_ratings.jpg (85.1 KB) - added by pavelevap 10 years ago.
before.png (80.7 KB) - added by obenland 10 years ago.
28148.diff (356 bytes) - added by obenland 10 years ago.
after.png (81.1 KB) - added by obenland 10 years ago.
28148.patch (1.1 KB) - added by ocean90 10 years ago.
after.2.png (102.0 KB) - added by ocean90 10 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
10 years ago

  • Component changed from General to Themes
  • Focuses ui administration added
  • Version changed from trunk to 3.9

@obenland
10 years ago

@obenland
10 years ago

@obenland
10 years ago

#2 @obenland
10 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

Not only localized, even in English it wraps when there are more than 100 reviews.

#3 @obenland
10 years ago

  • Component changed from Themes to Customize

#4 @celloexpressions
10 years ago

  • Component changed from Customize to Themes
  • Keywords commit added
  • Milestone changed from Future Release to 4.1

This is good to go, looks better stacked vertically anyway. FYI theme-install-previewer is actually completely independent of the Customizer, but looks the same.

@ocean90
10 years ago

@ocean90
10 years ago

#5 @ocean90
10 years ago

To reduce the gap between the screenshot and the description we should reduce the size of the ratings string, see 28148.patch and after.2.png.

#6 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 29959:

Theme install:

  • Move the "based on" string below the rating to avoid wrapping to a second line.
  • Reduce the gap between the theme screenshot and description.
  • Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

Note: See TracTickets for help on using tickets.