WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#28148 closed defect (bug) (fixed)

Small theme ratings glitch for localized versions

Reported by: pavelevap Owned by: SergeyBiryukov
Priority: low Milestone: 4.1
Component: Themes Version: 3.9
Severity: minor Keywords: has-patch commit
Cc: Focuses: ui, administration

Description

Can we have number of ratings related string bellow stars (as for plugins)? When there are many ratings, localized version is not looking good). See attached screenshot.

Attachments (6)

Theme_ratings.jpg​ (85.1 KB ) - added by pavelevap 12 years ago.
before.png​ (80.7 KB ) - added by obenland 12 years ago.
28148.diff​ (356 bytes ) - added by obenland 12 years ago.
after.png​ (81.1 KB ) - added by obenland 12 years ago.
28148.patch​ (1.1 KB ) - added by ocean90 12 years ago.
after.2.png​ (102.0 KB ) - added by ocean90 12 years ago.

Download all attachments as: .zip

Change History (12)

@pavelevap
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Component General → Themes
  • Focuses ui administration added
  • Version trunk → 3.9

@obenland
12 years ago

@obenland
12 years ago

@obenland
12 years ago

#2 @obenland
12 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → Future Release
  • Priority normal → low
  • Severity normal → minor

Not only localized, even in English it wraps when there are more than 100 reviews.

#3 @obenland
12 years ago

  • Component Themes → Customize

#4 @celloexpressions
12 years ago

  • Component Customize → Themes
  • Keywords commit added
  • Milestone Future Release → 4.1

This is good to go, looks better stacked vertically anyway. FYI theme-install-previewer is actually completely independent of the Customizer, but looks the same.

@ocean90
12 years ago

@ocean90
12 years ago

#5 @ocean90
12 years ago

To reduce the gap between the screenshot and the description we should reduce the size of the ratings string, see 28148.patch​ and after.2.png​.

#6 @SergeyBiryukov
12 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 29959:

Theme install:

  • Move the "based on" string below the rating to avoid wrapping to a second line.
  • Reduce the gap between the theme screenshot and description.
  • Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

Note: See TracTickets for help on using tickets.