Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28173 closed defect (bug) (fixed)

Add Media shortcut in TinyMCE is not working properly

Reported by: freshwebdev's profile freshwebdev Owned by: azaozz's profile azaozz
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords:
Focuses: administration Cc:

Description

I want to report a bug found in TinyMCE shortcut.

when you want to add image / media with shortcut shift + alt + M, appears a pop up, then I add the URL of an image from the web. After that I press the insert button to post. However, the image does not appear on tinyMCE editor.

Another story if I press the add button media. Bottom line, if through the shortcut, it did not work, but if the add button click through media is work.

best regards,
Bimo Hery Prabowo
http://freshwebdev.com

Attachments (1)

28173.patch (1.3 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (7)

#1 @azaozz
10 years ago

  • Milestone changed from Awaiting Review to 4.0

Confirmed. This is a weird bug. Caused by having <input type="button" accesskey="m"...> in Quicktags for the "image" button. As there are two instances of Quicktags, and the shortcut for activating the accesskeys is the same (Alt+Shift+M), the second "image" button is focused which sets window.wpActiveEditor to replycontent (despite that this button is usually not visible).

Are these accesskey attributes useful? I don't seem to be able to do anything after pressing the keys, at least in Chrome. If they are, we would need to fix them somehow for cases where more than one instance of Quicktags exists, if at all possible.

I'll look for a workaround for now. Can decide about the accesskeys in 4.1.

@azaozz
10 years ago

#2 @azaozz
10 years ago

In 28173.patch: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background.

#3 @azaozz
10 years ago

Related #29358.

#4 @nacin
10 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

Is this related to the editor width shortcuts no longer working in distraction-free writing?

#5 @azaozz
10 years ago

No, not related to the DFW width shortcuts. They work when TinyMCE is not focused.

#6 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 29603:

Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173

Note: See TracTickets for help on using tickets.